-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Mozartkugeln #11084
Open
moon-rabbitOFF
wants to merge
6
commits into
main
Choose a base branch
from
german-Mozartkugeln
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
taxonomy: Mozartkugeln #11084
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b2b7b22
Update categories.txt
moon-rabbitOFF 8f8cb37
Update categories.txt
moon-rabbitOFF 5b6e9d0
Update categories.txt
moon-rabbitOFF 986a310
Update categories.txt
moon-rabbitOFF f07213a
Update categories.txt
moon-rabbitOFF 94a55f2
Merge branch 'main' into german-Mozartkugeln
teolemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taxonomy wise, Klöse can be potato, meat (Fleischklöße), Quark (Topfenknödel), wheat (Hefeknödel) based, and more. Based on https://de.wikipedia.org/w/index.php?title=Klo%C3%9F&oldid=248171204#Varianten, putting all of them under the potato/cereal parent category sounds a bit inaccurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you are right. Do you think people will would put Fleischklöße under Knödel? I don't speak German well enough to know what would seem logical to german speakers.
We have for example a category "Creams" that refers to "Dairy creams". It is called just "Creams" because it is the common term for it, and people will understand that it refers to dairy creams and that products such as "Cream soups" or "Hazelnut creams" should not go under "Creams".
Do you think people think the Knödel as the potato or bread ones or as any type? If it people would think of any type, how would you call the category for the potato and bread ones? I would create a category for both the bread and cereal/bread ones together since a lot of products contain a mix of cereal and potato (e.g. https://world.openfoodfacts.org/product/4000137005752/semmel-knodel-dr-willi-knoll), similarly to the gnocchi