feat(plugin): add support to fetch ns from kubeconfig context #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilashshetty04
requested review from
tiagolobocastro,
sinhaashish,
niladrih,
Abhinandan-Purkait and
dsharma-dc
abhilashshetty04
force-pushed
the
plugin_ns
branch
4 times, most recently
from
e4e5e34 to
3ae784b
Compare
niladrih
approved these changes
Jan 27, 2025
abhilashshetty04
force-pushed
the
plugin_ns
branch
from
3ae784b to
a63a983
Compare
abhilashshetty04
force-pushed
the
plugin_ns
branch
2 times, most recently
from
69e4610 to
7a43718
Compare
abhilashshetty04
force-pushed
the
plugin_ns
branch
2 times, most recently
from
6bf1f7d to
85b570a
Compare
Abhinandan-Purkait
approved these changes
Jan 28, 2025
If '--namespace-from-context' flag is set then we fetch ns from the kubeconfig context. Its hidden to users now. Incase user has not given -n flag and --namespace-from-context we default to "mayastor". If they have used --namespace-from-context flag then we get ns from kubeconfig. If kubeconfig path is specified then we use client of that kubeconfig or else we get default kubeconfig client. Signed-off-by: Abhilash Shetty <[email protected]>
abhilashshetty04
force-pushed
the
plugin_ns
branch
from
85b570a to
6072389
Compare
tiagolobocastro
approved these changes
Jan 28, 2025
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If '---ns_from_context' flag is set then we fetch ns from the kubeconfig context, otherwise, --namespace arg is used. '---ns_from_context' takes precedence over -n if both are used.