-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl-mayastor: use namespace from current context #1575
Comments
What should the behaviour be like? Potential approaches:
I'd probably lean towards 2 or 3, perhaps 2. Open to comments here. |
Is this identifiable cleanly? context name can be potentially anything. 3 seems reasonable. |
I think 3 would be the best way here, as the one set to the context is usually deemed to be default for that context, so we can go with that, instead of using mayastor as hardcoded default? |
Yes I think we'd use current context and also take optional context name. |
Also this is also a breaking change for the users, if they were not specifying the namespace and have code/scripts :( |
I've discussed this with @niladrih and here's the proposal: |
Code changes are made as per openebs/mayastor-extensions#608, however, making this behaviour default will be done as part of next major release of Mayastor. |
Describe the bug
When using the plugin, it currently ignores the namespace from current context. You have to use -n
To Reproduce
Install mayastor in namespace not mayastor, like "openebs" e.g.
Running
kubectl mayastor get volumes
will fail, even when current context has the correct namespace (with kubie for example)Expected behavior
use the context :)
The text was updated successfully, but these errors were encountered: