-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5826: Create observability-primer.md (French version) #5833
Issue #5826: Create observability-primer.md (French version) #5833
Conversation
Hi @svrnm , As mentioned in the PR #5386 (comment), the spell checker is working fine, but it seems that the dictionary lacks many common French words. This is currently blocking the merge. Thanks, Isa |
@dmathieu, @codeboten, @marcalff, @theletterf, @cartermp, @austinlparker, @chalin and @svrnm: This PR is ready to be reviewed. |
Would it be okay if we imported the entire French dictionary into |
@bertysentry , importing the entire French dictionary could address many issues, but we would still need to add words manually because the spell checker:
While importing a dictionary would reduce the workload, these limitations would still require manual intervention. |
I agree that it isn't optimal nor sustainable.
Submitting PR(s) upstream to https://github.com/streetsidesoftware/cspell-dicts; for example, the last update seems to be streetsidesoftware/cspell-dicts#680. Any volunteers? It would be of benefit to all projects that use cSpell's fr_FR dictionaries. I'm going to create a separate issue to track this... --> #5870 |
* Fixed the markdown linter issue
* Updated the distributed-traces anchor
* Added the 192 unknown words to fr-mots.txt
Committed dmathieu's suggestion Co-authored-by: Damien Mathieu <[email protected]>
01cdd15
to
d079c74
Compare
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12636968824 |
IMPORTANT: (RE-)RUN
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iguitton - could you please address the issue highlighted by @bertysentry in #5870 (comment), strip the fr-mots.txt
to a minimum, and see if it all works?
@iguitton You know where to reach me if needed 😉 |
- Added fr-fr in .cspell.yaml - Skimmed the fr-mots.txt file to retain only the observability-specific terminology.
@chalin : As suggested by @bertysentry , I added fr-fr in the .cspell.yaml file and skimmed the fr-mots.txt file to retain only the observability-specific terminology. Only a few unknown words are now reported by the spelling check which is the expected behavior. Thank you both for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 😊
Took marcalff's comment into account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work,
I finally understood what we are working on ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very glad that we got the dictionary issues sorted out. Thanks again @bertysentry for spotting that!
Translated the observability-primer.md into French