-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Update localization docs to ensure that new dictionaries also get added to the sSpell config #5870
Comments
It might be worth first inquiring with the maintainer. Most other languages have complete dictionaries out-of-the-box. It seems strange that the French one is so incomplete. It could be a build issue rather than an issue with the collection of words? Does anyone want to lead the investigation, maybe first opening an issue over streetsidesoftware/cspell-dicts? |
It might also be worth asking what the Edit: I just posted a question, asking whether the K8s docs-fr folks used cSpell or not, see https://kubernetes.slack.com/archives/CG838BFT9/p1736018451325119. |
Maybe we're just missing |
@bertysentry - oh my, I had assumed that that had been added, yes that will probably be what is causing problems! |
We should add that as a necessary step for onboarding a language |
Right, we could add some explicit steps to the checklist of https://opentelemetry.io/docs/contributing/localization/#new-localizations. |
Edit (@chalin): this is being repurposed, given that problems were due to missing configuration on our part. For details see #5870 (comment).
Originally posted by @chalin in #5833 (comment)
I agree that it isn't optimal nor sustainable.
Submitting PR(s) upstream to https://github.com/streetsidesoftware/cspell-dicts; for example, the last update seems to be streetsidesoftware/cspell-dicts#680. Any volunteers? It would be of benefit to all projects that use cSpell's fr_FR dictionaries.
References:
/cc @open-telemetry/docs-fr-approvers
The text was updated successfully, but these errors were encountered: