Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong detection of helm-chart name in CI #804

Merged
merged 1 commit into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-chart-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
merged_commit=$(git log -1 --format='%H')
e2e_charts=$(git diff --name-only ${base_commit} ${merged_commit} | \
grep "^$CHARTS_DIR/" | \
grep -vE 'README.md|CI.md|common|*.sh' | \
grep -vE 'valuefiles.yaml|common|*.md|*.sh' | \
yongfengdu marked this conversation as resolved.
Show resolved Hide resolved
cut -d'/' -f2 | sort -u )
common_charts=$(git diff --name-only ${base_commit} ${merged_commit} | \
grep "^$CHARTS_DIR/common" | \
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/push-release-charts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
echo "${{ secrets.ACTION_TOKEN }}" | helm registry login ghcr.io -u opea --password-stdin
pushd $CHARTS_DIR/common
for chart in ${common_charts}; do
if [ ! -d $chart ]; then continue; fi
echo "Updating $chart"
helm dependency update ${chart}
helm package $chart
Expand All @@ -50,12 +51,13 @@ jobs:
# Update Examples
e2e_charts=$(git diff --name-only ${base_commit} ${merged_commit} | \
grep "^$CHARTS_DIR" | \
grep -vE 'README.md|valuefiles.yaml|common|*.sh' | \
grep -vE 'valuefiles.yaml|common|*.md|*.sh' | \
cut -d'/' -f2 | sort -u )
echo "Charts to be updated: $e2e_charts"
echo "${{ secrets.ACTION_TOKEN }}" | helm registry login ghcr.io -u opea --password-stdin
pushd $CHARTS_DIR
for chart in ${e2e_charts}; do
if [ ! -d $chart ]; then continue; fi
echo "Updating $chart"
helm dependency update ${chart}
helm package $chart
Expand Down