Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong detection of helm-chart name in CI #804

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

yongfengdu
Copy link
Collaborator

Filter files that are not helm charts

Description

Fix the failure of update helm charts
https://github.com/opea-project/GenAIInfra/actions/runs/13257577897/job/37006999398

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@yongfengdu yongfengdu requested a review from mkbhanda as a code owner February 13, 2025 07:14
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check could be for chart dirs, but that's small detail. Approved.

.github/workflows/push-release-charts.yaml Outdated Show resolved Hide resolved
Filter files that are not helm charts

Signed-off-by: Dolpher Du <[email protected]>
@yongfengdu
Copy link
Collaborator Author

Updated

Check could be for chart dirs, but that's small detail. Approved.

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkbhanda mkbhanda merged commit f81b81d into opea-project:main Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants