bring riseupvpn experiments to ooni android #393
Conversation
|
Thanks for this PR @cyBerta, I will follow it closely! |
|
In strings.xml the link to the test description is provided. There's a pending PR ooni/ooni.org#716 which will add the page to the ooni website. |
cyBerta
changed the title
app/src/main/res/values/strings.xml
Outdated
| <string name="TestResults_Details_Circumvention_Riseupvpn_Table_Header_Bridge">Bridged connections</string> | ||
| <string name="TestResults_Overview_Circumvention_Riseupvpn_Api_Blocked">blocked</string> | ||
| <plurals name="TestResults_Overview_Circumvention_Riseupvpn_Blocked"> | ||
| <item quantity="one">%d blocked</item> |
There was a problem hiding this comment.
NOTE TO SELF:
remove these quantity and add
- TestResults_Overview_Circumvention_Riseupvpn_Blocked_Singular
- TestResults_Overview_Circumvention_Riseupvpn_Blocked_Plural
There was a problem hiding this comment.
@lorenzoPrimi I think it would be better to generally use quantity strings, because there are languages (like Polish or Russian) that have more than 1 plural form. The translation would be grammatically wrong in these cases.
There was a problem hiding this comment.
@lorenzoPrimi this snippet illustrates it nicely with the Russian example of pineapples (ананас).
https://gist.github.com/Eeyore741/a0228dd9b7551daaf1fe8fc11a3548fc#file-plurals_en_ru-csv
There was a problem hiding this comment.
Unfortunately this would bring our translation system based on transifex, it's a much bigger change that can't be handled in this PR.
| @@ -133,6 +135,10 @@ | |||
| <item quantity="one">@string/TestResults_Summary_Websites_Hero_Reachable_Singular</item> | |||
| <item quantity="other">@string/TestResults_Summary_Websites_Hero_Reachable_Plural</item> | |||
| </plurals> | |||
| <plurals name="TestResults_Overview_Circumvention_RiseupVPN_Blocked" translatable="false"> | |||
| <item quantity="one">@string/TestResults_Overview_Circumvention_RiseupVPN_Blocked_Singular</item> | |||
| <item quantity="other">@string/TestResults_Overview_Circumvention_RiseupVPN_Blocked_Plural</item> | |||
There was a problem hiding this comment.
@cyBerta we still use the plurals here.
If you want to help us improve our translation system, let me know we can discuss it in a github issue.
Very appreciated.
There was a problem hiding this comment.
Sure, if it's not super urgent to be finished, I can definitely work on that. +1 for leaving this issue aside here and for opening an extra ticket for it.
There was a problem hiding this comment.
I'm gonna move ahead, merge this issue and opened another ticket about the plurals: ooni/translations#16
I still don't understand why our approach (string.xml for strings and untransatable.xml for plurals) it can cause that problem as we still use the quantities.
adding RiseupVPN to the circumvention test suite
there's a pending probe-engine PR which fixes the jumping and confusing time estimation of the running riseupvpn test (fix(urlgetter): progress over multiple collection tasks probe-engine#1124)