-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a RiseupVPN test description #716
Conversation
@bassosimone @hellais This PR is the last dependency of ooni/probe-android#393. We're exited to see the riseupvpn test in the ooni android client :) and would be happy to get some feedback if you think this PR is ok or needs changes. |
Thank you @cyBerta for writing a new RiseupVPN test, and thank you for the excellent test description! I have reviewed the test description and shared some minor edits: ddaee1e I look forward to seeing this new test shipped as part of the OONI Probe apps (cc' @bassosimone). Thanks again! <3 |
@cyBerta We'd love to give you credit for writing this exciting new test! May we do so? If so, how would you like to be credited? Thanks! |
Hi @agrabeli, thank you for reviewing the PR. You could give credits to the LEAP collective. Kwadronaut and me are involved there. |
It's perfect, thanks. I didn't even think of adding credits before. |
* master: Edited the copy in the OONI Probe CLI pages (#782) Add more prominent install OONI Probe button (#785) tweak timeout Move resources optimization to netlify.toml Re-order languages Add resources caching Add support for CLI tool installation (#741) Bump timeout Bump the hugo build timeout feat: list Defenders Protection Initiative as co-authors (#776) Uganda report (#775) fix: avoid redirs and broken links (#748) add a RiseupVPN test description (#716) Added UG testing button to OONI site (#742) Year in Review: OONI in 2020 post (#728)
ooni/probe-android#393 is kind of depending on this PR, since it includes some strings containing a link to the test description. The link is shown in the GUI in the test detail activity to provide additional information.