Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a RiseupVPN test description #716

Merged
merged 6 commits into from
Jan 12, 2021
Merged

add a RiseupVPN test description #716

merged 6 commits into from
Jan 12, 2021

Conversation

cyBerta
Copy link
Contributor

@cyBerta cyBerta commented Dec 7, 2020

ooni/probe-android#393 is kind of depending on this PR, since it includes some strings containing a link to the test description. The link is shown in the GUI in the test detail activity to provide additional information.

@cyBerta cyBerta changed the title [WIP] add a RiseupVPN test description add a RiseupVPN test description Dec 8, 2020
@cyBerta
Copy link
Contributor Author

cyBerta commented Jan 6, 2021

@bassosimone @hellais This PR is the last dependency of ooni/probe-android#393. We're exited to see the riseupvpn test in the ooni android client :) and would be happy to get some feedback if you think this PR is ok or needs changes.
Sorry, if you are the wrong persons to ping here.

@bassosimone
Copy link
Contributor

@cyBerta We are excited as well! I am personally looking forward to adding more functionality to the test. I am thinking, for example, of pluggable transports.

As for who could review the new copy, let me also Cc: @agrabeli.

Thank you for your great work!

@agrabeli
Copy link
Member

agrabeli commented Jan 8, 2021

Thank you @cyBerta for writing a new RiseupVPN test, and thank you for the excellent test description!

I have reviewed the test description and shared some minor edits: ddaee1e

I look forward to seeing this new test shipped as part of the OONI Probe apps (cc' @bassosimone). Thanks again! <3

@agrabeli
Copy link
Member

@cyBerta We'd love to give you credit for writing this exciting new test! May we do so? If so, how would you like to be credited? Thanks!

@cyBerta
Copy link
Contributor Author

cyBerta commented Jan 11, 2021

Hi @agrabeli, thank you for reviewing the PR. You could give credits to the LEAP collective. Kwadronaut and me are involved there.

@agrabeli
Copy link
Member

Thanks @cyBerta. I have added credits to the LEAP collective here: a17df78

Is this OK, or would you like us to edit this?

Thanks again for your amazing work!

@cyBerta
Copy link
Contributor Author

cyBerta commented Jan 12, 2021

It's perfect, thanks. I didn't even think of adding credits before.

@agrabeli agrabeli merged commit 06e3d37 into ooni:master Jan 12, 2021
hellais added a commit that referenced this pull request Feb 5, 2021
* master:
  Edited the copy in the OONI Probe CLI pages (#782)
  Add more prominent install OONI Probe button (#785)
  tweak timeout
  Move resources optimization to netlify.toml
  Re-order languages
  Add resources caching
  Add support for CLI tool installation (#741)
  Bump timeout
  Bump the hugo build timeout
  feat: list Defenders Protection Initiative as co-authors (#776)
  Uganda report (#775)
  fix: avoid redirs and broken links (#748)
  add a RiseupVPN test description (#716)
  Added UG testing button to OONI site (#742)
  Year in Review: OONI in 2020 post (#728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium Normal priority issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants