Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): immediately save before quitting or suspending #66

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

zoriya
Copy link
Contributor

@zoriya zoriya commented Jan 7, 2025

With the current defaults, closing nvim with :q or <c-w>q fails if still in the debounce_delay period.

@okuuva okuuva changed the title fix(default): imediatly save before quiting or suspending fix(config): immediately save before quitting or suspending Jan 7, 2025
@primeapple
Copy link
Collaborator

How lovely is that, I like it a lot!
I always use ZZ to close buffers so never realized this is missing!

Any objections @okuuva ?

@okuuva
Copy link
Owner

okuuva commented Jan 7, 2025

With the current defaults, closing nvim with :q or <c-w>q fails if still in the debounce_delay period.

While I haven't run into this myself (I use quite a short debounce delay) it sounds like something that might happen. And having those events in the default immediate_save list sounds like a good idea anyway.

I fixed some typos and changed the scope in the PR title, hope you don't mind. Thanks for the contribution!

@okuuva
Copy link
Owner

okuuva commented Jan 7, 2025

How lovely is that, I like it a lot! I always use ZZ to close buffers so never realized this is missing!

Any objections @okuuva ?

Ah you beat me to it again. None whatsoever, LGTM!

@okuuva okuuva merged commit d158bb0 into okuuva:main Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants