Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better url validation regex #220

Merged
merged 1 commit into from
Oct 19, 2023
Merged

better url validation regex #220

merged 1 commit into from
Oct 19, 2023

Conversation

dsavchenko
Copy link
Member

No description provided.

@dsavchenko dsavchenko added bug Something isn't working test-live labels Oct 19, 2023
@dsavchenko dsavchenko linked an issue Oct 19, 2023 that may be closed by this pull request
some valid url is not passed #219
Closed
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #220 (68a7c86) into master (99a7ffc) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   54.57%   54.84%   +0.26%     
==========================================
  Files          20       20              
  Lines        4306     4316      +10     
==========================================
+ Hits         2350     2367      +17     
+ Misses       1956     1949       -7
Files Coverage Δ
oda_api/misc_helpers.py 90.90% <100.00%> (ø)
tests/test_basic.py 94.00% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

volodymyrss
volodymyrss approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@volodymyrss volodymyrss merged commit 62f14c3 into master Oct 19, 2023
18 of 19 checks passed
This was referenced Oct 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyrss volodymyrss volodymyrss approved these changes

@burnout87 burnout87 burnout87 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working test-live
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some valid url is not passed
3 participants
@dsavchenko @burnout87 @volodymyrss