Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send e-mail upon completion of request (https://staging.odahub.fr/mmoda/) #553

Closed
andriineronov opened this issue Jul 13, 2023 · 11 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@andriineronov
Copy link

The frontend (or the dispatcher?) sends an e-mail upon submission of request, which is useful particularly for the Fermi/LAT service, where the requests can be long. However, the initial e-mail promises that I will get a new e-mail upon completion of the request. This second e-mail never comes..... Is this a bug (the behaviour observed at https://staging.odahub.fr/mmoda/)

@andriineronov andriineronov added the bug Something isn't working label Jul 13, 2023
@burnout87
Copy link
Collaborator

I have also recently noticed the missing of some done emails, but in very specific cases. I am investigating what the reason could be

@dsavchenko dsavchenko transferred this issue from oda-hub/mmoda-frontend-module Jul 13, 2023
@dsavchenko
Copy link
Member

I think I never got the completion emails when requesting nb2workflow products
What could be specific about this type of requests?

@burnout87
Copy link
Collaborator

It should not be related to the type of request and products, rather to a number of other conditions related to the configuration and the fields of the token

@dsavchenko
Copy link
Member

This issue persists for French staging. Do we have any updates/progress on it?

@burnout87
Copy link
Collaborator

I kept noticing the same behavior

@volodymyrss
Copy link
Member

volodymyrss commented Oct 16, 2023

in unige probably message queue piled up

@volodymyrss
Copy link
Member

this has to do with message passing on the nb2workflow backend

@dsavchenko
Copy link
Member

This issue was due to

  1. dispatcher config option email_sending_timeout_default_threshold was set to large number
  2. better url validation regex oda_api#220

Therefore, I close this one, as it is specific to https://staging.odahub.fr/mmoda

@burnout87 still notices email sending problems sometimes with other instances. Probably we need a separate issue then

@volodymyrss
Copy link
Member

thanks for updating!

This issue was due to

1. dispatcher config option `email_sending_timeout_default_threshold` was set to large number

2. [better url validation regex oda_api#220](https://github.com/oda-hub/oda_api/pull/220)

Therefore, I close this one, as it is specific to https://staging.odahub.fr/mmoda

@burnout87 still notices email sending problems sometimes with other instances. Probably we need a separate issue then

Here we decided to use inspect endpoint to investigate the cause. @burnout87 please follow-up in another issue

@volodymyrss
Copy link
Member

I note, however, that at the moment, https://staging.odahub.fr/mmoda/ fails to process callback and does not nominally complete any nb workflow. Since we use it for testing, it's important to have it live soon.

@dsavchenko
Copy link
Member

I note, however, that at the moment, https://staging.odahub.fr/mmoda/ fails to process callback and does not nominally complete any nb workflow. Since we use it for testing, it's important to have it live soon.

I just tried, and it was successfully able to reach the 'ready' state. So this issue is resolved there.

However, sometimes I notice the behavior when one of the POST requests which frontend sends to dispatcher ends up with 504: gateway timeout. In this case, there are no visible consequences, frontend just continues to show submitted state, but doesn't send any requests anymore.
This could be improved both in frontend, but we also need to investigate, what causes these timeouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants