Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove injection of property chains over 'develops from'. #3467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/ontology/catalog-v001.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
<uri name="http://purl.obolibrary.org/obo/uberon/bridge/uberon-bridge-to-wbbt.owl" uri="bridge/uberon-bridge-to-wbbt.owl"/>
<uri name="http://purl.obolibrary.org/obo/uberon/bridge/uberon-bridge-to-wbls.owl" uri="bridge/uberon-bridge-to-wbls.owl"/>
<uri name="http://purl.obolibrary.org/obo/uberon/bridge/uberon-bridge-to-xao.owl" uri="bridge/uberon-bridge-to-xao.owl"/>
<uri name="http://purl.obolibrary.org/obo/uberon/components/develops-from-chains.owl" uri="components/develops-from-chains.owl"/>
<uri name="http://purl.obolibrary.org/obo/uberon/components/disjoint_union_over.owl" uri="components/disjoint_union_over.owl"/>
<uri name="http://purl.obolibrary.org/obo/uberon/components/hra_depiction_3d_images.owl" uri="components/hra_depiction_3d_images.owl"/>
<uri name="http://purl.obolibrary.org/obo/uberon/components/hra_subset.owl" uri="components/hra_subset.owl"/>
Expand Down
13 changes: 0 additions & 13 deletions src/ontology/components/develops-from-chains.owl

This file was deleted.

1 change: 0 additions & 1 deletion src/ontology/uberon-edit.obo
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ treat-xrefs-as-equivalent: VSAO
treat-xrefs-as-is_a: BFO
treat-xrefs-as-is_a: VHOG
remark: Aurelie Comte, Bill Bug, Catherine Leroy, Duncan Davidson and Trish Whetzel are also contributors. However their ORCIDs were not found.
import: http://purl.obolibrary.org/obo/uberon/components/develops-from-chains.owl
import: http://purl.obolibrary.org/obo/uberon/components/disjoint_union_over.owl
import: http://purl.obolibrary.org/obo/uberon/components/hra_depiction_3d_images.owl
import: http://purl.obolibrary.org/obo/uberon/components/hra_subset.owl
Expand Down
7 changes: 1 addition & 6 deletions src/ontology/uberon.Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ $(OWLSRC): $(SRC) $(REPORTDIR)/$(SRC)-gocheck $(REPORTDIR)/$(SRC)-iconv
-o $@

# Step 2: Reasoning.
# For the temporary injection of property chains, see
# <https://github.com/obophenotype/uberon/issues/2381>
DEVELOPS_FROM_CHAIN=$(COMPONENTSDIR)/develops-from-chains.owl
# The 'materialize' step is too resource-intensive for the GitHub
# Action runners, so we leave it out when running online QC checks, see
# <https://github.com/obophenotype/uberon/pull/3087#issuecomment-1755553647>
Expand All @@ -128,13 +125,11 @@ MATERIALIZE=
else
MATERIALIZE = materialize -T $(CONFIGDIR)/basic_properties.txt -r elk
endif
$(POSTPROCESS_SRC): $(OWLSRC) $(BRIDGEDIR)/uberon-bridge-to-bfo.owl $(DEVELOPS_FROM_CHAIN)
$(POSTPROCESS_SRC): $(OWLSRC) $(BRIDGEDIR)/uberon-bridge-to-bfo.owl
$(ROBOT) merge -i $(OWLSRC) -i $(BRIDGEDIR)/uberon-bridge-to-bfo.owl \
-i $(DEVELOPS_FROM_CHAIN) \
relax $(MATERIALIZE) \
reason -r elk --exclude-duplicate-axioms true \
--equivalent-classes-allowed asserted-only \
unmerge -i $(DEVELOPS_FROM_CHAIN) \
annotate -O $(URIBASE)/uberon.owl -V $(RELEASE)/uberon.owl -o $@

# Step 3: Postprocessing. We merge some files that are derived from the
Expand Down
Loading