Remove injection of property chains over 'develops from'. #3467
+1
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For years, Uberon had been injecting the following property chains over RO’s 'develops from' relation (RO:0002202): 'develops from' o 'part of' SubPropertyOf 'develops from' 'part of' o 'develops from' SubPropertyOf 'develops from' An attempt to upstream those property chains into RO did not find any support, and in fact the weak consensus is rather that those chains serve no useful purpose (oborel/obo-relations#814). So, we completely remove those chains from Uberon.
matentzn
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Technically LGTM. My full approval is given that
An oborel/obo-relations#814 to upstream those property chains into RO did not find any support, and in fact the weak consensus is rather that those chains serve no useful purpose.
Found consensus among the Chris and Jim.
|
Without any explicit expression of consensus in two weeks (or any explicit expression of dissent), in two weeks from now I'll go ahead and assume the implicit consensus in oborel/obo-relations#814 is enough. That issue has been going on for long enough. |
|
Fair, I would take the same decision as you! |
balhoff
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For years, Uberon had been injecting the following property chains over RO’s 'develops from' relation (RO:0002202):
An attempt to upstream those property chains into RO did not find any support, and in fact the weak consensus is rather that those chains serve no useful purpose.
So, this PR completely removes those chains from Uberon.
closes #2723