Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/consensus/tendermint: Add support for state sync #2882

Merged
merged 5 commits into from
Aug 4, 2020
Merged

go/consensus/tendermint: Add support for state sync #2882

merged 5 commits into from
Aug 4, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented May 3, 2020 •
edited
Loading

Fixes #2880.
Based on #2881.

TODO

  • Cleanup.
    • Make checkpoint parameters configurable (should likely be consensus parameters).
  • More tests.
  • Wait for Tendermint Core 0.34.

@kostko kostko mentioned this pull request May 3, 2020
Merged
2 tasks
@kostko kostko force-pushed the kostko/feature/tm-light-client branch 3 times, most recently from c33045c to 1cbdbc1 Compare May 5, 2020 09:40
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch from 17d63ec to 69c1173 Compare May 5, 2020 09:42
@kostko kostko added the s:blocked Status: blocked on other work label May 5, 2020
@kostko kostko mentioned this pull request May 5, 2020
Closed
9 tasks
@kostko kostko force-pushed the kostko/feature/tm-light-client branch 7 times, most recently from 624a5c0 to 2ddcbd7 Compare May 6, 2020 08:28
@kostko kostko linked an issue May 6, 2020 that may be closed by this pull request
State sync for the Tendermint consensus backend #2880
Closed
@kostko kostko force-pushed the kostko/feature/tm-light-client branch from 2ddcbd7 to 20107f5 Compare May 6, 2020 09:16
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch from 69c1173 to e15fbec Compare May 6, 2020 11:52
@codecov
Copy link

codecov bot commented May 6, 2020 •
edited
Loading

Codecov Report

Merging #2882 into master will decrease coverage by 0.14%.
The diff coverage is 53.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2882      +/-   ##
==========================================
- Coverage   68.62%   68.48%   -0.15%     
==========================================
  Files         383      385       +2     
  Lines       37470    37871     +401     
==========================================
+ Hits        25715    25937     +222     
- Misses       8479     8636     +157     
- Partials     3276     3298      +22
Impacted Files Coverage Δ
go/consensus/genesis/genesis.go 21.05% <0.00%> (-5.27%) ⬇️
go/consensus/tendermint/apps/scheduler/genesis.go 33.81% <16.66%> (+1.43%) ⬆️
go/consensus/tendermint/abci/mux.go 61.25% <33.75%> (-9.95%) ⬇️
go/consensus/tendermint/full/light.go 54.16% <46.66%> (-9.00%) ⬇️
go/consensus/tendermint/light/client.go 49.56% <49.56%> (ø)
go/consensus/tendermint/full/statesync.go 63.49% <63.49%> (ø)
go/consensus/tendermint/crypto/signature.go 75.00% <66.66%> (-6.82%) ⬇️
go/consensus/tendermint/full/full.go 63.72% <75.86%> (+0.40%) ⬆️
go/consensus/tendermint/abci/state.go 69.38% <81.81%> (-0.89%) ⬇️
go/common/grpc/grpc.go 83.18% <100.00%> (-1.84%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0b2f3...b3912eb. Read the comment docs.

@kostko kostko changed the base branch from kostko/feature/tm-light-client to master May 6, 2020 12:09
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch from e15fbec to 5629f67 Compare May 11, 2020 09:15
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch from 5629f67 to 29d84f7 Compare May 21, 2020 13:18
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch 4 times, most recently from 0232940 to 13f4763 Compare June 23, 2020 10:25
@kostko kostko mentioned this pull request Jun 23, 2020
Merged
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch 4 times, most recently from f045a35 to 48007b8 Compare June 26, 2020 09:52
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch from f875175 to 8b51d06 Compare July 4, 2020 11:46
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch from 8b51d06 to bf15ccb Compare July 19, 2020 19:55
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch 2 times, most recently from 7e5e893 to 4cad04b Compare July 30, 2020 12:41
@kostko kostko removed the s:blocked Status: blocked on other work label Jul 30, 2020
@kostko
Copy link
Member Author

kostko commented Jul 30, 2020

Rebased on top of 0.34.0-rc1 which was released today.

@kostko
Copy link
Member Author

kostko commented Jul 30, 2020

Our test suite found the following issue in 0.34.0-rc1: tendermint/tendermint#5179 (happens both in e2e/runtime/history-reindex and e2e/runtime/txsource).

@kostko kostko added the s:blocked Status: blocked on other work label Jul 30, 2020
kostko
kostko commented Jul 30, 2020
View reviewed changes
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch 5 times, most recently from 810eadf to 9a80e5e Compare August 3, 2020 07:44
@kostko kostko removed the s:blocked Status: blocked on other work label Aug 3, 2020
Yawning
Yawning reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/fixture-data/net-runner/default.json is showing in the change list with "No changes".

@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch 4 times, most recently from f2582a1 to a6a9413 Compare August 3, 2020 20:18
Yawning
Yawning reviewed Aug 4, 2020
View reviewed changes
@kostko kostko force-pushed the kostko/feature/tm-state-sync-test branch from a6a9413 to b3912eb Compare August 4, 2020 12:01
@kostko kostko merged commit 3c03fc2 into master Aug 4, 2020
@kostko kostko deleted the kostko/feature/tm-state-sync-test branch August 4, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yawning Yawning Yawning approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State sync for the Tendermint consensus backend
2 participants
@kostko @Yawning