Basic consensus light client support #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kostko
force-pushed
the
kostko/feature/tm-light-client
branch
2 times, most recently
from
c62db02 to
c33045c
Compare
This was referenced May 5, 2020
kostko
force-pushed
the
kostko/feature/tm-light-client
branch
3 times, most recently
from
c2c0d08 to
608d347
Compare
Codecov Report
@@ Coverage Diff @@
## master #2881 +/- ##
==========================================
+ Coverage 67.56% 67.74% +0.18%
==========================================
Files 350 352 +2
Lines 34036 34215 +179
==========================================
+ Hits 22995 23179 +184
+ Misses 8079 8074 -5
Partials 2962 2962
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/tm-light-client
branch
from
608d347 to
504db8e
Compare
kostko
commented
May 5, 2020
kostko
force-pushed
the
kostko/feature/tm-light-client
branch
from
504db8e to
e8d1621
Compare
kostko
force-pushed
the
kostko/feature/tm-light-client
branch
3 times, most recently
from
624a5c0 to
2ddcbd7
Compare
A public consensus services worker enables any full consensus node to expose light client services to other nodes that may need them (e.g., they are needed to support light clients). The worker can be enabled using --worker.consensusrpc.enabled and is disabled by default. Enabling the public consensus services worker exposes the light consensus client interface over publicly accessible gRPC.
kostko
force-pushed
the
kostko/feature/tm-light-client
branch
from
2ddcbd7 to
20107f5
Compare
Yawning
approved these changes
May 6, 2020
| func (m *Metadata) EncodedHash() hash.Hash { | ||
| var hh hash.Hash | ||
|
|
||
| hh.From(m) |
There was a problem hiding this comment.
Doesn't need to be now, and we do this all over the place, but at some point we should add func NewFrom(v interface{}) Hash.
There was a problem hiding this comment.
Ah, good idea! I'll do this in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of #2440, required for #2880.
TODO