Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disclosure date #879

Merged
merged 19 commits into from
Feb 28, 2025
Merged

Disclosure date #879

merged 19 commits into from
Feb 28, 2025

Conversation

tschmidtb51
Copy link
Contributor

@tschmidtb51
Disclosure Date
4b694e3 
- addresses parts of oasis-tcs#782
- update name and description in JSON schema
@tschmidtb51
Disclosure Date
6a0df71 
- addresses parts of oasis-tcs#782
- adapt prose to match schema
- add rule on `disclosure_date` in future
@tschmidtb51
Disclosure Date
5d9002b 
- addresses parts of oasis-tcs#782
- adapt guidance on size
@tschmidtb51
Disclosure Date
bc9a183 
- addresses parts of oasis-tcs#782
- add conversion rules
@tschmidtb51
Disclosure Date
b006461 
- addresses parts of oasis-tcs#782
- update path in test 6.1.37
@tschmidtb51
Disclosure Date
dcc987a 
- addresses parts of oasis-tcs#782
- update overview in vulnerabilities section
@tschmidtb51
Disclosure Date
f66606e 
- addresses parts of oasis-tcs#782
- adapt examples
@tschmidtb51 tschmidtb51 added editor-revision already worked on in the editor revision csaf 2.1 csaf 2.1 work labels Feb 26, 2025
@tschmidtb51 tschmidtb51 requested a review from sthagen February 26, 2025 17:27
@tschmidtb51 tschmidtb51 self-assigned this Feb 26, 2025
@tschmidtb51
Copy link
Contributor Author

tschmidtb51 commented Feb 26, 2025 •
edited
Loading

sthagen
sthagen approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tschmidtb51 tschmidtb51 mentioned this pull request Feb 27, 2025
Open
@tschmidtb51
Copy link
Contributor Author

tschmidtb51 commented Feb 27, 2025 •
edited
Loading

  • check mandatory test for non-draft with disclosure_date after latest entry in revision_history and TLP:CLEAR

@tschmidtb51
Disclosure Date
7d9d451 
- addresses parts of oasis-tcs#782
- add mandatory test 6.1.45 for inconsistent disclosure date
- add valid examples
- add invalid examples
@tschmidtb51
Disclosure Date
b13b272 
- addresses parts of oasis-tcs#782
- remove unnecessary lines from example
@tschmidtb51
Disclosure Date
07a6877 
- addresses parts of oasis-tcs#782
- add optional test 6.2.33 for past disclosure date after release
- add invalid example
- add valid example
@tschmidtb51
Disclosure Date
62154b7 
- addresses parts of oasis-tcs#782
- add 6.1.45 to bind.txt
@tschmidtb51
Disclosure Date
69eb92d 
- addresses parts of oasis-tcs#782
- add invalid timezone example for 6.1.45
- add valid timezone example for 6.1.45
- add invalid timezone example for 6.2.33
- add valid timezone example for 6.2.33
@tschmidtb51
Disclosure Date
24109fd 
- addresses parts of oasis-tcs#782, oasis-tcs#469
- add invalid examples for 6.1.37 (leap second and year)
- add valid examples for 6.1.37 (leap second and year)
@tschmidtb51
Daten and Time
c41d8f6 
- addresses parts of oasis-tcs#469
- correct filename
- exclude leap seconds files from testing
- exclude invalid date-time format from testing
@tschmidtb51 tschmidtb51 marked this pull request as ready for review February 28, 2025 19:14
sthagen
sthagen approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did some small edits.

@tschmidtb51 tschmidtb51 merged commit ab891f7 into oasis-tcs:editor-revision-2025-02-26 Feb 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen sthagen approved these changes

Assignees

@tschmidtb51 tschmidtb51

Labels
csaf 2.1 csaf 2.1 work editor-revision already worked on in the editor revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tschmidtb51 @sthagen