feat: add mandatory test 6.1.37 #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report |
tschmidtb51
requested changes
Feb 27, 2025
There was a problem hiding this comment.
Please
- tighten the regex as discussed,
- check leap seconds/years
- use changed path from Disclosure date oasis-tcs/csaf#879
domachine
force-pushed
the
197-mandatory-test-6.1.37
branch
from
942047f to
c257dcb
Compare
domachine
changed the base branch from
196-csaf-2.1
to
217-csaf-2.1-test-script
|
Coverage after merging 197-mandatory-test-6.1.37 into 217-csaf-2.1-test-script
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
@tschmidtb51 Okay, I addressed the issues. |
tschmidtb51
requested changes
Feb 28, 2025
| date: { type: 'string' }, | ||
| }, | ||
| }, | ||
| initial_release_date: { type: 'string' }, |
There was a problem hiding this comment.
Missing the current_release_date
| if (!isValidDate(date)) { | ||
| ctx.errors.push({ | ||
| instancePath: path, | ||
| message: `invalid date`, |
There was a problem hiding this comment.
Can we be more specific and tell what exactly was wrong with the date?
There was a problem hiding this comment.
Mhm, we could divide into two errors. One where the date does not match specified format and one where the date is invalid.
Comment on lines
+152
to
+154
| validateDate( | ||
| doc.document?.tracking?.initial_release_date, | ||
| '/document/tracking/initial_release_date' | ||
| ) |
There was a problem hiding this comment.
Missing current_release_date
| doc.vulnerabilities?.forEach((vulnerabiltiy, vulnerabilityIndex) => { | ||
| const prefix = `/vulnerabilities/${vulnerabilityIndex}` | ||
|
|
||
| validateDate(vulnerabiltiy.disclosure_date, `${prefix}/disclosure_date`) |
There was a problem hiding this comment.
Suggested change
| validateDate(vulnerabiltiy.disclosure_date, `${prefix}/disclosure_date`) | |
| validateDate(vulnerabiltiy.disclosure_date, `/${prefix}/disclosure_date`) |
There was a problem hiding this comment.
Ah interesting, do you have a test case where this fails? In my understanding, this would end up in two forward slashes.
| ['2024-01-01T00:00:00.0Z', true], | ||
| ['2024-01-01T00:00:00.11111111Z', true], | ||
| ['2024-01-01T00:00:00+01:00', true], | ||
| ['2024-01-01T00:00:00.111111+01:00', true], |
There was a problem hiding this comment.
I would like to add a few more things here:
Suggested change
| ['2024-01-01T00:00:00.111111+01:00', true], | |
| ['2024-01-01T00:00:00.111111+01:00', true], | |
| ['2024-02-29T00:00:00.987564+01:00', true], | |
| ['2015-06-30T10:29:60-13:30', true], | |
| ['2015-06-30T23:59:60+00:00', true], | |
| ['2015-07-01T06:59:60+07:00', true], | |
| ['2016-12-31T00:00:60+23:59', true], | |
| ['2016-12-31T23:59:60+00:00', true], | |
| ['2017-01-01T02:59:60+03:00', true], | |
| ['2017-01-01T02:59:60+04:00', false], | |
| ['2024-02-30T00:00:00+01:00', false], | |
| ['2024-04-31T00:00:00+01:00', false], | |
| ['2024-13-31T00:00:00+01:00', false], |
There was a problem hiding this comment.
Mhm, I'm not sure if just the boolean was flipped but many of these cases fail for me:
These dates are invalid, but marked as valid in the sample
2015-06-30T10:29:60-13:302015-06-30T10:29:60-13:302015-06-30T23:59:60+00:002015-07-01T06:59:60+07:002016-12-31T00:00:60+23:592016-12-31T23:59:60+00:002017-01-01T02:59:60+03:002017-01-01T02:59:60+04:00
These dates are valid, but marked as invalid in the sample
2024-02-30T00:00:00+01:002024-04-31T00:00:00+01:00
There was a problem hiding this comment.
Mhm, I'm not sure if just the boolean was flipped but many of these cases fail for me:
These dates are invalid, but marked as valid in the sample
2015-06-30T10:29:60-13:302015-06-30T10:29:60-13:302015-06-30T23:59:60+00:002015-07-01T06:59:60+07:002016-12-31T00:00:60+23:592016-12-31T23:59:60+00:002017-01-01T02:59:60+03:002017-01-01T02:59:60+04:00These dates are valid, but marked as invalid in the sample
2024-02-30T00:00:00+01:002024-04-31T00:00:00+01:00
I'm pretty sure the boolean is right. The dates covered in the valid part refer to leap seconds.
For the invalid part: According to my count the February 2024 just had 29 days, not 30 and the April 30, not 31.
Am I missing something?
There was a problem hiding this comment.
I think, the dates covered in the valid part have 60 seconds which is invalid IMHO. I think in RFC 3339, 10:29:60 is expressed as 10:30:00 e.g.
For the invalid part: 2024-02-30T00:00:00+01:00 is marked with timezone offset +01:00 which converts to the following UTC date: 2024-02-29T23:00:00Z which is valid, since (as you noted) february had 29 days.
I hope, my understanding here is correct 🙈
domachine
force-pushed
the
197-mandatory-test-6.1.37
branch
from
c257dcb to
35a73ff
Compare
|
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
domachine
force-pushed
the
197-mandatory-test-6.1.37
branch
from
35a73ff to
b5d6a72
Compare
|
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@tschmidtb51 I added the check for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.