Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial #748

Merged
merged 1 commit into from
May 31, 2024
Merged

Editorial #748

merged 1 commit into from
May 31, 2024

Conversation

tschmidtb51
Copy link
Contributor

@tschmidtb51
Editorial
117c40c 
- addresses review comment from oasis-tcs#747
- use American English for "flavored"
@tschmidtb51 tschmidtb51 added editorial mostly nits and consistency csaf 2.1 csaf 2.1 work labels May 29, 2024
@tschmidtb51 tschmidtb51 requested a review from sthagen May 29, 2024 20:24
@tschmidtb51 tschmidtb51 self-assigned this May 29, 2024
@tschmidtb51 tschmidtb51 mentioned this pull request May 29, 2024
Merged
sthagen
sthagen approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although two sentences in a row - both exposing a MAY - do make me wonder if these guide or confuse implementers. Maybe we should scan the complete specification (not in this PR) and verify our use of MAY is as intended and minimal.

@tschmidtb51 tschmidtb51 merged commit 3581490 into oasis-tcs:editor-revision-2024-05-29 May 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen sthagen approved these changes

Assignees

@tschmidtb51 tschmidtb51

Labels
csaf 2.1 csaf 2.1 work editorial mostly nits and consistency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tschmidtb51 @sthagen