-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add party multiplier
#747
Add party multiplier
#747
Conversation
- addresses parts of oasis-tcs#580 - add new party "multiplier" to JSON schema
- addresses parts of oasis-tcs#580 - adopt prose to reflect schema
- addresses parts of oasis-tcs#580, oasis-tcs#673 - add conversion rule
@mprpic Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor nitpicks. LGTM!
csaf_2.1/prose/edit/src/schema-elements-02-props-01-document.md
Outdated
Show resolved
Hide resolved
csaf_2.1/prose/edit/src/schema-elements-02-props-01-document.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (plus minus some nits and maybe an illustrating example). Thanks for providing the text.
Co-authored-by: Martin Prpič <[email protected]>
Co-authored-by: Martin Prpič <[email protected]>
- addresses review comment from oasis-tcs#747 - use American English for "flavored"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- addresses review comment of oasis-tcs#747 - rephrase "separated" into "regrouped"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks.
The motion to accept the pull request as suggested in #747 and include it into CSAF 2.1, has passed. It automatically carried on 2024-06-07 23:00 UTC. |
4861537
into
oasis-tcs:editor-revision-2024-05-29
multiplier
#580