Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add party multiplier #747

Merged

Conversation

tschmidtb51
Copy link
Contributor

- addresses parts of oasis-tcs#580
- add new party "multiplier" to JSON schema
- addresses parts of oasis-tcs#580
- adopt prose to reflect schema
- addresses parts of oasis-tcs#580, oasis-tcs#673
- add conversion rule
@tschmidtb51 tschmidtb51 requested a review from sthagen May 29, 2024 16:35
@tschmidtb51 tschmidtb51 self-assigned this May 29, 2024
@tschmidtb51
Copy link
Contributor Author

@mprpic Please review.

Copy link
Contributor

@mprpic mprpic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor nitpicks. LGTM!

Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (plus minus some nits and maybe an illustrating example). Thanks for providing the text.

tschmidtb51 added a commit to tschmidtb51/csaf that referenced this pull request May 29, 2024
- addresses review comment from oasis-tcs#747
- use American English for "flavored"
@tschmidtb51 tschmidtb51 mentioned this pull request May 29, 2024
@tschmidtb51 tschmidtb51 added motion This item has a motion pending and removed tc-discussion-needed labels May 29, 2024
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

- addresses review comment of oasis-tcs#747
- rephrase "separated" into "regrouped"
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@tschmidtb51 tschmidtb51 marked this pull request as ready for review May 31, 2024 21:25
@santosomar
Copy link
Contributor

The motion to accept the pull request as suggested in #747 and include it into CSAF 2.1, has passed. It automatically carried on 2024-06-07 23:00 UTC.
https://groups.oasis-open.org/discussion/motion-for-747

@santosomar santosomar merged commit 4861537 into oasis-tcs:editor-revision-2024-05-29 Jun 11, 2024
5 checks passed
@tschmidtb51 tschmidtb51 removed the motion This item has a motion pending label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csaf 2.1 csaf 2.1 work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants