Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker-compose.dev.yml): make dev workflow easier #94

Merged
merged 3 commits into from
Nov 21, 2023
Merged

feat(docker-compose.dev.yml): make dev workflow easier #94

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62c1718
feat(docker-compose.dev.yml): make dev workflow easier
MartinMinkov Nov 21, 2023
07fd706
fix(docker-compose.dev.yml): remove localhost binding from port 3085 …
MartinMinkov Nov 21, 2023
a592928
style(docker-compose.yml): replace double quotes with single quotes f…
MartinMinkov Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion docker-compose.dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,28 @@
version: '3.3'

services:
mina:
image: ${MINA}
container_name: mina
ports:
- '6060:6060'
- '8302:8302'
- '127.0.0.1:3085:3085'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 127.0.0.1:3085:3085 correct or should this be 3085:3085?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does work; the difference between the two is that with 127.0.0.1:3085:3085, it specifies that the port is only bound to localhost, and will only be accessible by the host machine, while 3085:3085 is accessible by any machine on the network. This detail doesn't matter in this context, but I changed it to 3085:3085 since I think it's more clear 👍

restart: always
env_file:
- ./.env
volumes:
- '$HOME/keys:/root/keys:ro'
- '$HOME/.mina-config:/root/.mina-config'
command: >
daemon
--metrics-port 6060
--archive-address archive:3086
--insecure-rest-server
networks:
- archive
- mina

archive:
image: ${ARCHIVE}
container_name: archive
Expand Down Expand Up @@ -65,7 +87,6 @@ services:
command: npm run dev
volumes:
- .:/app
- /app/node_modules
networks:
- archive

Expand Down
Loading
Loading