feat(docker-compose.dev.yml): make dev workflow easier #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivo25
approved these changes
Nov 21, 2023
docker-compose.dev.yml
Outdated
| ports: | ||
| - '6060:6060' | ||
| - '8302:8302' | ||
| - '127.0.0.1:3085:3085' |
There was a problem hiding this comment.
is 127.0.0.1:3085:3085 correct or should this be 3085:3085?
There was a problem hiding this comment.
It does work; the difference between the two is that with 127.0.0.1:3085:3085, it specifies that the port is only bound to localhost, and will only be accessible by the host machine, while 3085:3085 is accessible by any machine on the network. This detail doesn't matter in this context, but I changed it to 3085:3085 since I think it's more clear 👍
…to allow connections from all network interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.