Code

Milestone Picker#5

Code

Open

m133225 wants to merge 21 commits intonus-fboa2016-ht:masternus-fboa2016-ht/HubTurbo:masterfrom m133225:m133225-milestone-pickerm133225/HubTurbo:m133225-milestone-pickerCopy head branch name to clipboard

+817-11

Commits

Commits on Feb 3, 2016

• Initial version of milestone picker

  m133225

  committed
  d775202

  Copy full SHA for d775202

• Removed leftover debug statement.

  m133225

  committed
  d3cc6c4

  Copy full SHA for d3cc6c4

Commits on Feb 4, 2016

• Removed debug statements for testing github's api

  m133225

  committed
  0ed1596

  Copy full SHA for 0ed1596

• Fixed comparing the milestones based on the description instead of its name/title.

  m133225

  committed
  30229d3

  Copy full SHA for 30229d3

• Allow user to unselect a label by clicking on it (again). Modified ChangeMilestoneAction to accept Optional<Integer> for milestones instead. Null values can now be passed to TurboIssue's setMilestone.

  m133225

  committed
  148dd7a

  Copy full SHA for 148dd7a

• Changed keyboard shortcut M to show the milestone picker instead of using the milestone selector on GitHub. Added functionality to move highlight up and down on the milestone picker using UP and DO…

  Show description for 2717d08
  m133225

  committed
  2717d08

  Copy full SHA for 2717d08

Commits on Feb 5, 2016

• Fixed initial highlight not prioritising an already-selected label. Fixed check to see if milestone has been modified, now checks by value instead of comparing objects. Removed leftover debug state…

  Show description for 239fd38
  m133225

  committed
  239fd38

  Copy full SHA for 239fd38

• LEFT and RIGHT arrows are used to move the highlighted on the milestones instead. DOWN arrow is used to select a label, and UP arrow is used to unselect a label. Fix to initial highlight label not …

  Show description for 29661c2
  m133225

  committed
  29661c2

  Copy full SHA for 29661c2

• Extracted helper functions that involve finding or getting the highlighted/selected milestone. Added comments to the public methods in MilestonePickerDialog. Other refactoring changes.

  m133225

  committed
  1e952cc

  Copy full SHA for 1e952cc

• Added vertical gap in between milestones in a milestone group. Made PickerMilestone comparable with other milestones, based on due date. Milestones without a due date are deemed to be less 'planned…

  Show description for de1c85e
  m133225

  committed
  de1c85e

  Copy full SHA for de1c85e

• Refactoring in classes related to milestone picker.

  m133225

  committed
  a297933

  Copy full SHA for a297933

• Merge branch 'master' into m133225-milestone-picker

  m133225

  committed
  cd14bfa

  Copy full SHA for cd14bfa

Commits on Feb 14, 2016

• Added milestone picker logic which relies on text input. Clicking of milestones is not working yet. Modified MilestonePickerDialog return type to Pair since we have to know both the button pressed …

  Show description for 7a4d5db
  m133225

  committed
  7a4d5db

  Copy full SHA for 7a4d5db

Commits on Feb 17, 2016

• Implemented setMilestone method in DummyRepoState. Modified Logic's replaceIssueMilestone to set the new milestone found in the returned issue rather than assuming that the change was successful.

  m133225

  committed
  647031f

  Copy full SHA for 647031f

• Extracted logic and state of MilestonePicker into MilestonePickerState to make testing of the logic easier.

  m133225

  committed
  3b8e1a9

  Copy full SHA for 3b8e1a9

• Removed dependency on dialog for PickerMilestone for easier testing. This also means that the mouse clicks handler have to be manually set. Added basic test of toggleMilestone logic.

  m133225

  committed
  b8349eb

  Copy full SHA for b8349eb

• Fixed dialog not updated when there is a changed made by mouse clicks.

  m133225

  committed
  de6a821

  Copy full SHA for de6a821

Commits on Feb 18, 2016

• Fixed incorrect handling of unassigning milestones.

  m133225

  committed
  3bd184a

  Copy full SHA for 3bd184a

Commits on Feb 20, 2016

• Some method name changes and refactoring. More test cases added.

  m133225

  committed
  6374f24

  Copy full SHA for 6374f24

Commits on Feb 23, 2016

• Minor refactoring in MilestonePickerDialog and MilestonePickerState.

  m133225

  committed
  a8b5ede

  Copy full SHA for a8b5ede

• Moved processInput into a new MilestonePickerState constructor. Refactored showMilestonePicker method to be clearer.

  m133225

  committed
  4d08c40

  Copy full SHA for 4d08c40