Milestone Picker #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angeMilestoneAction to accept Optional<Integer> for milestones instead. Null values can now be passed to TurboIssue's setMilestone.
…sing the milestone selector on GitHub. Added functionality to move highlight up and down on the milestone picker using UP and DOWN arrow keys (however, we still cannot select using keyboard)
…ixed check to see if milestone has been modified, now checks by value instead of comparing objects. Removed leftover debug statement.
…nes instead. DOWN arrow is used to select a label, and UP arrow is used to unselect a label. Fix to initial highlight label not prioritising a selected label (previous one was still buggy).
…ghted/selected milestone. Added comments to the public methods in MilestonePickerDialog. Other refactoring changes.
…ickerMilestone comparable with other milestones, based on due date. Milestones without a due date are deemed to be less 'planned for' and thus treated as further away than those with due dates. Handled error case when there are no milestones available to highlight when using up and down arrow keys.
…milestones is not working yet. Modified MilestonePickerDialog return type to Pair since we have to know both the button pressed and milestone selection result, which fixes removing milestone when Cancel is pressed.
…eplaceIssueMilestone to set the new milestone found in the returned issue rather than assuming that the change was successful.
…e to make testing of the logic easier.
…This also means that the mouse clicks handler have to be manually set. Added basic test of toggleMilestone logic.
…tored showMilestonePicker method to be clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.