Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated title from headline to name in profile #36

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

floWetzels
Copy link
Collaborator

This PR updates the schema term for the ISA property title. Currently it is mapped to headline. However, the RO-Crate specification requires the root data entity to have a name specified (see nfdi4plants/ARCtrl#472). The Google Dataset Search also shows the title of a dataset through this property. Thus, this PR updates the profiles for Investigation and Study accordingly.

@floWetzels floWetzels requested review from HLWeil and stuzart December 6, 2024 15:04
@HLWeil
Copy link
Member

HLWeil commented Dec 9, 2024

I understand the need for such a change, but just to make sure: If you look into non-ARC datasets in the Google Dataset search, what kind of names are they using? Would this match semantically with our Titles?

@floWetzels
Copy link
Collaborator Author

It's inconsistent, I don't see a strict pattern. But I would say that most names are in the style of titles.

@floWetzels
Copy link
Collaborator Author

@HLWeil What do you think of the description I added to the mapping file?

@HLWeil
Copy link
Member

HLWeil commented Dec 19, 2024

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants