-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] RO-Crate export missing MUST fields #472
Comments
There are some available APIs to query against: When searching for license scanning and gitlab this popped up: |
Yes, this can be done in the CI-Pipeline. Can you point me to an example RO-Crate containing a license? |
I think we don't have any example yet, @j-bauer. But as I said I could insert this as an argument in the arc-export tool, so you would only need to provide this when calling the export |
|
Correct, PR #488 changed I guess we should also change |
Yup makes sense to change them to name 👍 Would leave the Assay as is atm, maybe we actually align it more with the study, see nfdi4plants/ARC-specification#86 |
Copying my comment from the related discussion thread
I think 1 is easy to solve in this repo right now, 2-3 will take some revision cycles as it changes specs, and 4. is a little more effort implementation-wise in this repo. |
In the future, please first update the profile, i am currently aggregating needed changes on the profile and specs, and the codebase being ahead of the profile is something i did not expect. |
That's not the case though, see nfdi4plants/isa-ro-crate-profile#36 |
Yeah i Messe up looking at the Release branch sorry
…________________________________
From: Florian Wetzels ***@***.***>
Sent: Wednesday, 26 February 2025 18:03:33
To: nfdi4plants/ARCtrl ***@***.***>
Cc: Kevin Schneider ***@***.***>; Comment ***@***.***>
Subject: Re: [nfdi4plants/ARCtrl] [BUG] RO-Crate export missing MUST fields (Issue #472)
Correct, PR #488<#488> changed headline to name
In the future, please first update the profile, i am currently aggregating needed changes on the profile and specs, and the codebase being ahead of the profile is something i did not expect.
That's not the case though, see nfdi4plants/isa-ro-crate-profile#36<nfdi4plants/isa-ro-crate-profile#36>
—
Reply to this email directly, view it on GitHub<#472 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFCZPVYEKGSIBOU2555PEKT2RXXWLAVCNFSM6AAAAABRLE2G4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGY3DSOJWG4>.
You are receiving this because you commented.Message ID: ***@***.***>
[floWetzels]floWetzels left a comment (nfdi4plants/ARCtrl#472)<#472 (comment)>
Correct, PR #488<#488> changed headline to name
In the future, please first update the profile, i am currently aggregating needed changes on the profile and specs, and the codebase being ahead of the profile is something i did not expect.
That's not the case though, see nfdi4plants/isa-ro-crate-profile#36<nfdi4plants/isa-ro-crate-profile#36>
—
Reply to this email directly, view it on GitHub<#472 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFCZPVYEKGSIBOU2555PEKT2RXXWLAVCNFSM6AAAAABRLE2G4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGY3DSOJWG4>.
You are receiving this because you commented.Message ID: ***@***.***>
|
The investigation object in the RO-Crate export does not necessarily have a
license
andname
field, however, they are required by the RO-Crate specification.Could the gitlab CI detect an existing license and insert it into the arc export command? @j-bauer
The text was updated successfully, but these errors were encountered: