feat: NR 328461 add CLS browser golden signals #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and summary metrics
entityBot
suggested changes
Jan 6, 2025
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
* Error PARSING domainType: 'browser-application' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "NUMBER": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 15, column: 9] (through reference chain: LinkedHashMap["cumulativeLayoutShift75Percentile"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])
* Error PARSING domainType: 'browser-application' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "NUMBER": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 27, column: 9] (through reference chain: LinkedHashMap["cumulativeLayoutShift75Percentile"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])
|
|
shivalagisetty
changed the title
entityBot
approved these changes
Jan 7, 2025
entityBot
approved these changes
Jan 7, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ric in golden and summary metrics
|
We cannot arbitrarily add units on our side. Those need to be changed/allowed on the upstream systems before we can change our validations. Added more context here: link |
vetusbs
reviewed
Jan 16, 2025
…ric in golden and summary metrics
entityBot
approved these changes
Jan 17, 2025
entityBot
approved these changes
Jan 17, 2025
entityBot
approved these changes
Jan 17, 2025
entityBot
approved these changes
Jan 17, 2025
entityBot
approved these changes
Jan 17, 2025
entityBot
approved these changes
Jan 17, 2025
entityBot
approved these changes
Jan 21, 2025
entityBot
approved these changes
Jan 21, 2025
bhansa-nr
pushed a commit
to bhansa-nr/entity-definitions
that referenced
this pull request
Jan 23, 2025
* add: Add cumulative layout shift (75 percentile) metric to golden metrics * add: Rename cumulative layout shift metric and update summary metrics * add: Include "NUMBER" as a valid unit in the golden metrics schema * add: Include "NUMBER" as a valid unit in the summary metrics schema * fix: Rename cumulative layout shift metric for consistency in golden and summary metrics * add: Include "NUMBER" as a valid unit in golden and summary metrics schemas * fix: Remove "NUMBER" as a valid unit from golden and summary metrics schemas * fix: Update unit from COUNT to NUMBER for cumulative layout shift metric in golden and summary metrics * fix: Change unit from NUMBER to STRING for cumulative layout shift metric in golden and summary metrics * fix: Add "STRING" as a valid unit in golden metrics schema * fix: Change unit from STRING to COUNT for cumulative layout shift metric in golden and summary metrics * fix: Remove "STRING" from valid units in golden metrics schema --------- Co-authored-by: Mili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
The Browser is extending the support of CLS (Cumulative Layout Shift ) a core web vital which is missing as the other two are already added.
Ticket : https://new-relic.atlassian.net/browse/NR-328461
Checklist
identifierwill be unique and valid.