Skip to content

Commit

Permalink
feat: NR 328461 add CLS browser golden signals (#1839)
Browse files Browse the repository at this point in the history
* add: Add cumulative layout shift (75 percentile) metric to golden metrics

* add: Rename cumulative layout shift metric and update summary metrics

* add: Include "NUMBER" as a valid unit in the golden metrics schema

* add: Include "NUMBER" as a valid unit in the summary metrics schema

* fix: Rename cumulative layout shift metric for consistency in golden and summary metrics

* add: Include "NUMBER" as a valid unit in golden and summary metrics schemas

* fix: Remove "NUMBER" as a valid unit from golden and summary metrics schemas

* fix: Update unit from COUNT to NUMBER for cumulative layout shift metric in golden and summary metrics

* fix: Change unit from NUMBER to STRING for cumulative layout shift metric in golden and summary metrics

* fix: Add "STRING" as a valid unit in golden metrics schema

* fix: Change unit from STRING to COUNT for cumulative layout shift metric in golden and summary metrics

* fix: Remove "STRING" from valid units in golden metrics schema

---------

Co-authored-by: Mili <[email protected]>
  • Loading branch information
shivalagisetty and mborroni authored Jan 21, 2025
1 parent 5038220 commit 9d28186
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
8 changes: 8 additions & 0 deletions entity-types/browser-application/golden_metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ interactionToNextPaint75PercentileS:
from: PageViewTiming
eventId: entityGuid
eventName: appName
cumulativeLayoutShift75Percentile:
title: Cumulative layout shift (75 percentile)
unit: COUNT
query:
select: percentile(cumulativeLayoutShift, 75)
from: PageViewTiming
eventId: entityGuid
eventName: appName
errors:
title: Errors
unit: COUNT
Expand Down
4 changes: 4 additions & 0 deletions entity-types/browser-application/summary_metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ interactionToNextPaint75PercentileS:
goldenMetric: interactionToNextPaint75PercentileS
unit: SECONDS
title: Interaction to next paint (75 percentile) (s)
cumulativeLayoutShift75Percentile:
goldenMetric: cumulativeLayoutShift75Percentile
unit: COUNT
title: Cumulative layout shift (75 percentile)
errors:
goldenMetric: errors
unit: COUNT
Expand Down

0 comments on commit 9d28186

Please sign in to comment.