feat: gh-actions-language-server

[disrupted]

---

name: Pull Request
about: Submit a pull request
title: 'add GitHub Actions language server'

Closes #2737

[chrisgrieser]

I just gave this one a try, and noticed that the config does not work initially, due to the usage of yaml.github as a filetype. While I get the idea to not start this language server on every yaml file, I do not think that the filetype yaml.github is automatically in nvim by default? I have to manually set them in my github action files, at least.

[disrupted]

I just gave this one a try, and noticed that the config does not work initially, due to the usage of yaml.github as a filetype. While I get the idea to not start this language server on every yaml file, I do not think that the filetype yaml.github is automatically in nvim by default? I have to manually set them in my github action files, at least.

that's true. I recommend defining this pattern for GitHub workflows:

vim.filetype.add({
  pattern = {
    ['.*/%.github[%w/]+workflows[%w/]+.*%.ya?ml'] = 'yaml.github',
  },
})

We would either have to upstream this into Neovim core ftdetect or add a section to the docs

[justinmk]

We would either have to upstream this into Neovim core ftdetect or add a section to the docs

The docs item in these configs is intended for that, it's definitely worth mentioning there.

[justinmk]

Note that root_dir can be a function, so it could inspect the contents of every .yaml file to decide if it's a GH workflow.

I'll leave that as a followup for now.

[comatory]

I don't think there's a standard way to identify GitHub YAML anyway. I mean, there are some specifics like inputs, maybe? But they're optional - there's also the slight difference between Workflow & Action so detecting this wouldn't be reliable anyway I think.