Generate non-nullable properties on model as required #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DjordyKoert
force-pushed
the
feat/2111-set-required-fields-on-object
branch
from
1aa3759 to
a387f9c
Compare
|
failing PHPUnit (8.1, 6.3.*) is unrelated. |
DjordyKoert
force-pushed
the
feat/2111-set-required-fields-on-object
branch
from
9e0e52c to
534be18
Compare
DjordyKoert
force-pushed
the
feat/2111-set-required-fields-on-object
branch
from
ff9d18b to
daadd14
Compare
DjordyKoert
changed the title
|
@GuilhemN any chance you can look at this? 😄 |
|
As I understood, if property is nullable but must be in response, it should also have required marking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue: #2111