Expand tests with required field

nelmio · Oct 27, 2023 · a387f9c · a387f9c
1 parent c7396d5
commit a387f9c
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/OpenApiPhp/Util.php b/OpenApiPhp/Util.php
@@ -155,8 +155,6 @@ public static function getOperationParameter(OA\Operation $operation, $name, $in
      * it is expected to be a string nested property.
      *
      * @see OA\AbstractAnnotation::$_nested
-     *
-     * @param $class
      */
     public static function getChild(OA\AbstractAnnotation $parent, $class, array $properties = []): OA\AbstractAnnotation
     {

diff --git a/Tests/Functional/FunctionalTest.php b/Tests/Functional/FunctionalTest.php
@@ -242,6 +242,15 @@ public function testUserModel()
                     ],
                 ],
                 'schema' => 'User',
+                'required' => [
+                    'id',
+                    'roles',
+                    'money',
+                    'creationDate',
+                    'users',
+                    'status',
+                    'dateAsInterface',
+                ],
             ],
             json_decode($this->getModel('User')->toJson(), true)
         );
@@ -428,6 +437,17 @@ public function testSymfonyConstraintDocumentation()
             'required' => [
                 'propertyNotBlank',
                 'propertyNotNull',
+                'propertyAssertLength',
+                'propertyRegex',
+                'propertyCount',
+                'propertyChoice',
+                'propertyChoiceWithCallback',
+                'propertyChoiceWithCallbackWithoutClass',
+                'propertyChoiceWithMultiple',
+                'propertyExpression',
+                'propertyRange',
+                'propertyLessThan',
+                'propertyLessThanOrEqual',
             ],
             'properties' => [
                 'propertyNotBlank' => [

diff --git a/Tests/Functional/ValidationGroupsFunctionalTest.php b/Tests/Functional/ValidationGroupsFunctionalTest.php
@@ -75,6 +75,10 @@ public function testConstraintDefaultGroupsAreRespectedWhenReadingAnnotations()
             ],
             'type' => 'object',
             'schema' => 'SymfonyConstraintsDefaultGroup',
+            'required' => [
+                'property',
+                'propertyInDefaultGroup',
+            ],
         ];
 
         $this->assertEquals(