Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jlc/deploy mfe s3 action #3

Merged
merged 5 commits into from
May 9, 2024
Merged

Jlc/deploy mfe s3 action #3

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81e155e
fix: env vars reading for built
johanseto Apr 22, 2024
12cddcd
feat: add deploy mfe-s3-action
johanseto Apr 22, 2024
55d22d2
fix!: remove mfe_config to use the action env
johanseto Apr 22, 2024
f3834af
Revert "fix!: remove mfe_config to use the action env"
johanseto May 2, 2024
b04ab36
fix: dont override original env var of the process
johanseto May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,3 @@ ENTERPRISE_MARKETING_URL=''
ENTERPRISE_MARKETING_UTM_SOURCE=''
ENTERPRISE_MARKETING_UTM_CAMPAIGN=''
ENTERPRISE_MARKETING_FOOTER_UTM_MEDIUM=''
APP_ID=''
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the load env variables commit set this empty and then our MFE_CONFIG_API_URL doesn't work.

frontend-app-gradebook/webpack.prod.config.js

Lines 22 to 25 in 81e155e

const envConfig = dotenv.parse(fs.readFileSync('.env'));
Object.keys(envConfig).forEach(k => {
process.env[k] = envConfig[k];
});

I mean /eox-nelp/... because is changed by ''

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those .env values should be the default values however those should be overridden by this image

if that is not happening that means that the code that you showed has an error and we should fix that instead of modifying the env files.

I remember that one way to fix the development variables was just to set the environment variables, that overrode a specific value of the env.development however I choose this approach because this updates the whole file but the intention never was to remove the priority that the environment variables have

Copy link
Collaborator Author

@johanseto johanseto May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrey-canon b04ab36

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :D

MFE_CONFIG_API_URL=''
Loading