Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jlc/deploy mfe s3 action #3

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

johanseto
Copy link
Collaborator

@johanseto johanseto commented Apr 22, 2024

Description

Add mfe gradebook action deployer.

Checklist

  • Repo vars configured

  • s3 multiple mfe bucket created

  • CDN configure with bucket

  • Fixed the override of original process env vars.
    b04ab36

@andrey-canon
Copy link
Collaborator

Please merge previous prs and make a rebase since there are too many commits that doesn't belong to this pr

cherry-pick of other mfe.
this is like a cherrypick of this pr in learning.
https://github.com/nelc/frontend-app-learning/pull/27/files
This is an error generated of the load of paragonTheme plugin.
.env Outdated
@@ -30,5 +30,3 @@ ENTERPRISE_MARKETING_URL=''
ENTERPRISE_MARKETING_UTM_SOURCE=''
ENTERPRISE_MARKETING_UTM_CAMPAIGN=''
ENTERPRISE_MARKETING_FOOTER_UTM_MEDIUM=''
APP_ID=''
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the load env variables commit set this empty and then our MFE_CONFIG_API_URL doesn't work.

const envConfig = dotenv.parse(fs.readFileSync('.env'));
Object.keys(envConfig).forEach(k => {
process.env[k] = envConfig[k];
});

I mean /eox-nelp/... because is changed by ''

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those .env values should be the default values however those should be overridden by this image

if that is not happening that means that the code that you showed has an error and we should fix that instead of modifying the env files.

I remember that one way to fix the development variables was just to set the environment variables, that overrode a specific value of the env.development however I choose this approach because this updates the whole file but the intention never was to remove the priority that the environment variables have

Copy link
Collaborator Author

@johanseto johanseto May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :D

johanseto added 2 commits May 2, 2024 17:15
With this change I store in a different var in memory the original environment vars.
This with the purpose of keep them and not override.
Dotenv dont override them and also with .env analysis this ones would not be override too.
@johanseto johanseto merged commit f27a953 into open-rc/palm.nelp May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants