Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate publication tab to the explore page #744

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

onursumer
Copy link
Collaborator

@onursumer onursumer commented Jan 9, 2025

@onursumer onursumer requested a review from inodb January 9, 2025 18:51
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
htan-portal-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 8:44pm

@inodb
Copy link
Collaborator

inodb commented Jan 13, 2025

@onursumer Awesome work!

A few things I spotted:

  • Some overlapping column on my macbook screen
    image
  • Maybe we can show the sorting icon? Since it's sorted by publication date
    image
  • Some publications have a dot in the title, while others don't. Remove the dot everywhere?
  • Maybe we can hide a few columns by default to make the page less overwhelming:
    image

Some potential follow up items:

  • Would it be possible to add an "Assays" column (hidden by default), that would show number of assays for that publication?
  • Maybe a checkbox to allow users to select publications for filtering?

@onursumer onursumer force-pushed the add-explore-publication-tab branch from f584937 to 4de25ac Compare January 22, 2025 20:42
@inodb inodb added the enhancement New feature or request label Jan 22, 2025
@inodb inodb merged commit 2927123 into ncihtan:master Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new publications Tab in the explore page
2 participants