fixes custom field contrib functionality #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
approved these changes
Feb 6, 2024
Kircheneer
force-pushed
the
lk-fix-custom-fields
branch
from
8be9c61 to
b1f1981
Compare
jdrew82
requested changes
Feb 8, 2024
|
@Kircheneer can we get the conflicts fixed? |
- Rename `CustomFieldAnnotation.name` to `CustomFieldAnnotation.key` - Keep around backwards compatibility for using `name` - Clarify supported types of fields for identifiers - Add tests for custom fields in identifiers
Kircheneer
force-pushed
the
lk-fix-custom-fields
branch
2 times, most recently
from
a34fc8f to
119cb74
Compare
|
Done! |
Kircheneer
force-pushed
the
lk-fix-custom-fields
branch
from
119cb74 to
2de3cc3
Compare
Kircheneer
force-pushed
the
lk-fix-custom-fields
branch
from
2de3cc3 to
c0fa2da
Compare
Kircheneer
added a commit
to Kircheneer/nautobot-plugin-ssot
that referenced
this pull request
Feb 21, 2024
fixes custom field contrib functionality
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #291
CustomFieldAnnotation.nametoCustomFieldAnnotation.keyname