Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug with custom fields in _identifiers #291

Closed
wants to merge 2 commits into from

Conversation

Kircheneer
Copy link
Contributor

Fixes #290 for the custom field part

@Kircheneer Kircheneer self-assigned this Dec 4, 2023
@Kircheneer Kircheneer requested a review from a team as a code owner December 4, 2023 14:53
@Kircheneer Kircheneer mentioned this pull request Dec 4, 2023
@jdrew82
Copy link
Contributor

jdrew82 commented Jan 2, 2024

Has this been confirmed to fix the issue with CustomFields where you need to pass the CF key and not the label? When I was trying to use this for a personal project I found that using the label simply created the key in custom_field_data dict and breaks GraphQL and doesn't display correctly in the UI.

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82
Copy link
Contributor

jdrew82 commented Jan 10, 2024

Guess the test results answer my previous question. We need to revert the CustomField key to be is_global as Is Global is not valid for a CustomField key. This also goes for the CustomFieldAnnotation where name actually needs to be the key form of the CustomField.

@Kircheneer
Copy link
Contributor Author

See #350

@Kircheneer Kircheneer closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NautobotModel.get_from_db() doesn't work for custom fields and many to many relationships
2 participants