run-browser: Replaced PhantomJS with Puppeteer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ossdev07 <[email protected]>
naugtur
reviewed
Nov 25, 2019
Comment on lines
-72
to
-75
| if (phantom) { | ||
| files.unshift(path.join(__dirname, '/lib/phantom-function-bind-shim.js')); | ||
| } | ||
|
|
naugtur
reviewed
Nov 25, 2019
| @@ -69,10 +67,6 @@ function createHandler(filename, reports, phantom, mockserverHandler) { | |||
| files = files.map(normalizePath); | |||
| files.unshift(path.join(__dirname, '/lib/override-log.js')); | |||
There was a problem hiding this comment.
I think there might be a better way to get logs from puppeteer than this, but it's ok to leave it as is for now.
|
Thanks, @naugtur for reviewing the patch, if it looks good to you when can I expect this PR to be merged? |
|
@naugtur if the patch looks good to you can you please merge this pull request. |
|
Sorry, busy week with family. |
|
Thanks for merging this @naugtur, I have raised another pull request to resolve the failing test cases with puppeteer in xhr, Please have a look: naugtur/xhr#184 |
|
@naugtur it will be really helpful if you could make a release with the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhantomJS is an unmaintained project, replaced phantomjs dependency with the puppeteer.
Closes naugtur/xhr#180