Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn older clients about ChannelListeners #4097

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Warn older clients about ChannelListeners #4097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/murmur/Messages.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,25 @@ void Server::msgAuthenticate(ServerUser *uSource, MumbleProto::Authenticate &msg
sendMessage(uSource, mpsug);
}

if (uSource->uiVersion < 0x010400 && Meta::mp.iMaxListenersPerChannel > 0 && Meta::mp.iMaxListenerProxiesPerUser > 0) {
// The server has the ChannelListener feature enabled but the client that connects doesn't have version 1.4.0 or newer
// meaning that this client doesn't know what ChannelListeners are. Thus we'll send that user a text-message informing
// about this.
MumbleProto::TextMessage mptm;

if (Meta::mp.bAllowHTML) {
mptm.set_message("<b>[WARNING]</b>: This server has the <b>ChannelListener</b> feature enabled but your client version does not support it. "
"This means that users <b>might be listening to what you are saying in your channel without you noticing!</b> "
"You can solve this issue by upgrading to Mumble 1.4.0 or newer.");
} else {
mptm.set_message("[WARNING]: This server has the ChannelListener feature enabled but your client version does not support it. "
"This means that users might be listening to what you are saying in your channel without you noticing! "
"You can solve this issue by upgrading to Mumble 1.4.0 or newer.");
}

sendMessage(uSource, mptm);
}

log(uSource, "Authenticated");

emit userConnected(uSource);
Expand Down