Warn older clients about ChannelListeners #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture ChannelListener will be introduced with Mumble 1.4.0 but older clients will not know what these are. Thus they won't show them in their UI which could lead to users being listened to without noticing. In order to solve this issue, this commit implements a logic on the Server that'll inform older clients about this possibility by sending them a TextMessage right after they have authenticated (and after they have received the server's welcome text).
Krzmbrzl
force-pushed
the
feature-listen-to-channel
branch
from
45f4a80 to
db465f0
Compare
Krzmbrzl
added a commit
to Krzmbrzl/mumble
that referenced
this pull request
Jan 14, 2021
Clients < 1.4.0 don't know about the new ChannelListener feature and thus there is no indication in the UI for them. In order to make sure that users know that they could potentially be listened to without seeing anything in the UI, a warning message was introduced in mumble-voip#4097. There was an error in the implementation however causing this warning to not be sent by the server if there are no explicit limits on the amount of channel listeners via the server configuration. The bug was that "no limit" was expressed as -1 but the check for whether these features are enabled checked for > 0. The fix is simply to check for != 0 instead. Fixes mumble-voip#4687
Krzmbrzl
added a commit
that referenced
this pull request
Jan 14, 2021
… about ChannelListener Clients < 1.4.0 don't know about the new ChannelListener feature and thus there is no indication in the UI for them. In order to make sure that users know that they could potentially be listened to without seeing anything in the UI, a warning message was introduced in #4097. There was an error in the implementation however causing this warning to not be sent by the server if there are no explicit limits on the amount of channel listeners via the server configuration. The bug was that "no limit" was expressed as -1 but the check for whether these features are enabled checked for > 0. The fix is simply to check for != 0 instead. Fixes #4687
Kissaki
added
feature-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChannelListener will be introduced with Mumble 1.4.0 but older clients
will not know what these are. Thus they won't show them in their UI
which could lead to users being listened to without noticing.
In order to solve this issue, this commit implements a logic on the
Server that'll inform older clients about this possibility by sending
them a TextMessage right after they have authenticated (and after they
have received the server's welcome text).
Thanks to @streaps for pointing this problem out in #4011