Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent sccache-dist from running as root #1680

Closed
wants to merge 1 commit into from
Closed

Prevent sccache-dist from running as root #1680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/bin/sccache-dist/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::{Mutex, MutexGuard};
use std::time::{Duration, Instant};

#[cfg(any(
all(target_os = "linux", target_arch = "x86_64"),
target_os = "freebsd"
))]
use libc::{geteuid, uid_t};
Comment on lines +28 to +32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd import it within the function, or use it's full path since it's the only place it's actually used.


#[cfg_attr(target_os = "freebsd", path = "build_freebsd.rs")]
mod build;

Expand All @@ -35,12 +41,27 @@ use cmdline::{AuthSubcommand, Command};

pub const INSECURE_DIST_SERVER_TOKEN: &str = "dangerously_insecure_server";

#[cfg(any(
all(target_os = "linux", target_arch = "x86_64"),
target_os = "freebsd"
))]
fn exit_if_root() {
let euid: uid_t = unsafe { geteuid() };

if euid == 0 {
println!("This program should not be executed as root.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
println!("This program should not be executed as root.");
eprintln!("This program should not be executed as root.");

std::process::exit(1);
}
}

// Only supported on x86_64 Linux machines and on FreeBSD
#[cfg(any(
all(target_os = "linux", target_arch = "x86_64"),
target_os = "freebsd"
))]
fn main() {
exit_if_root();

init_logging();

let incr_env_strs = ["CARGO_BUILD_INCREMENTAL", "CARGO_INCREMENTAL"];
Expand Down
Loading