Prevent sccache-dist from running as root #1680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1680 +/- ##
==========================================
- Coverage 30.98% 30.94% -0.05%
==========================================
Files 53 53
Lines 20014 20014
Branches 9700 9700
==========================================
- Hits 6202 6193 -9
- Misses 7920 7922 +2
- Partials 5892 5899 +7 ☔ View full report in Codecov by Sentry. |
|
I will fix the test |
Xuanwo
approved these changes
Mar 22, 2023
drahnr
reviewed
Mar 22, 2023
| let euid: uid_t = unsafe { geteuid() }; | ||
|
|
||
| if euid == 0 { | ||
| println!("This program should not be executed as root."); |
There was a problem hiding this comment.
Suggested change
| println!("This program should not be executed as root."); | |
| eprintln!("This program should not be executed as root."); |
drahnr
reviewed
Mar 22, 2023
Comment on lines
+47
to
+32
| #[cfg(any( | ||
| all(target_os = "linux", target_arch = "x86_64"), | ||
| target_os = "freebsd" | ||
| ))] | ||
| use libc::{geteuid, uid_t}; |
There was a problem hiding this comment.
nit: I'd import it within the function, or use it's full path since it's the only place it's actually used.
|
@sylvestre a particular reason this was closed? |
|
Yeah, I won't have time to work on it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.