Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add results link to experiments table #11990

Merged
merged 5 commits into from
Jan 15, 2025
Merged

feat: add results link to experiments table #11990

merged 5 commits into from
Jan 15, 2025

Conversation

mikewilli
Copy link
Contributor

@mikewilli mikewilli commented Jan 3, 2025 •
edited by RJAK11
Loading

Because

  • it is impossible to tell if an experiment has results without clicking into it
  • it can be useful to see a list of experiments with/without results
  • it can be useful to navigate directly to the experiment's results

This commit

  • adds a results link to the experiments table if results exist

Fixes #10946
image

@RJAK11 RJAK11 marked this pull request as ready for review January 15, 2025 17:49
@RJAK11 RJAK11 requested a review from brennie as a code owner January 15, 2025 17:49
jaredlockhart
jaredlockhart reviewed Jan 15, 2025
View reviewed changes
experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/table.html Outdated
{% if experiment.show_results_url %}
<a href="{% url "nimbus-results" slug=experiment.slug %}">View Results</a>
{% else %}
<a>View Results</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh maybe just changed this to N/A 🙏

@RJAK11 RJAK11 force-pushed the 10946-results-link branch from 67f8613 to 7eac4d9 Compare January 15, 2025 19:30
jaredlockhart
jaredlockhart approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay perfect thank you @RJAK11 and @mikewilli 🙏

@RJAK11 RJAK11 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into mozilla:main with commit 89b9d53 Jan 15, 2025
15 checks passed
@RJAK11 RJAK11 deleted the 10946-results-link branch January 15, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart approved these changes

@brennie brennie Awaiting requested review from brennie brennie is a code owner

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add results link to experiment row when results are available
4 participants
@mikewilli @jaredlockhart @yashikakhurana @RJAK11