Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugins from export set (backport #3227) #3241

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions moveit_core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ add_subdirectory(collision_detection_fcl)


install(
<<<<<<< HEAD
TARGETS
collision_detector_bullet_plugin
moveit_butterworth_filter
Expand Down Expand Up @@ -176,13 +177,56 @@ install(
moveit_transforms
moveit_utils
EXPORT export_${PROJECT_NAME}
=======
TARGETS moveit_collision_detection
moveit_collision_detection_bullet
moveit_collision_detection_fcl
moveit_collision_distance_field
moveit_constraint_samplers
moveit_distance_field
moveit_dynamics_solver
moveit_exceptions
moveit_kinematic_constraints
moveit_kinematics_base
moveit_kinematics_metrics
moveit_macros
moveit_planning_interface
moveit_planning_scene
moveit_robot_model
moveit_robot_state
moveit_robot_trajectory
moveit_smoothing_base
moveit_test_utils
moveit_trajectory_processing
moveit_transforms
moveit_utils
EXPORT moveit_coreTargets
>>>>>>> b5eb4deb3 (Remove plugins from export set (#3227))
LIBRARY DESTINATION lib
ARCHIVE DESTINATION lib
RUNTIME DESTINATION bin
INCLUDES DESTINATION include
)

<<<<<<< HEAD
ament_export_targets(export_${PROJECT_NAME} HAS_LIBRARY_TARGET)
=======
install(
TARGETS collision_detector_bullet_plugin
collision_detector_fcl_plugin
moveit_acceleration_filter
moveit_acceleration_filter_parameters
moveit_butterworth_filter
moveit_butterworth_filter_parameters
moveit_ruckig_filter
moveit_ruckig_filter_parameters
EXPORT moveit_core_pluginTargets
LIBRARY DESTINATION lib
ARCHIVE DESTINATION lib
RUNTIME DESTINATION bin)

ament_export_targets(moveit_coreTargets HAS_LIBRARY_TARGET)
>>>>>>> b5eb4deb3 (Remove plugins from export set (#3227))
ament_export_dependencies(
angles
Bullet
Expand Down
23 changes: 23 additions & 0 deletions moveit_kinematics/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,21 @@ set(THIS_PACKAGE_INCLUDE_DIRS
)

set(THIS_PACKAGE_LIBRARIES
<<<<<<< HEAD
moveit_cached_ik_kinematics_base
moveit_cached_ik_kinematics_plugin
moveit_kdl_kinematics_plugin
moveit_lma_kinematics_plugin
moveit_srv_kinematics_plugin
)
=======
cached_ik_kinematics_parameters moveit_cached_ik_kinematics_base
kdl_kinematics_parameters srv_kinematics_parameters)

set(THIS_PACKAGE_PLUGINS
moveit_cached_ik_kinematics_plugin moveit_kdl_kinematics_plugin
moveit_srv_kinematics_plugin)
>>>>>>> b5eb4deb3 (Remove plugins from export set (#3227))

set(THIS_PACKAGE_INCLUDE_DEPENDS
pluginlib
Expand Down Expand Up @@ -66,6 +75,7 @@ install(
INCLUDES DESTINATION include
)

<<<<<<< HEAD
ament_export_targets(export_${PROJECT_NAME} HAS_LIBRARY_TARGET)
ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS} orocos_kdl_vendor)

Expand All @@ -83,5 +93,18 @@ if(BUILD_TESTING)
# Run all lint tests in package.xml except those listed above
ament_lint_auto_find_test_dependencies()
endif()
=======
install(
TARGETS ${THIS_PACKAGE_PLUGINS}
EXPORT ${PROJECT_NAME}PluginTargets
LIBRARY DESTINATION lib
ARCHIVE DESTINATION lib
RUNTIME DESTINATION bin
INCLUDES
DESTINATION include/moveit_kinematics)

ament_export_targets(${PROJECT_NAME}Targets HAS_LIBRARY_TARGET)
ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS})
>>>>>>> b5eb4deb3 (Remove plugins from export set (#3227))

ament_package(CONFIG_EXTRAS ConfigExtras.cmake)
17 changes: 17 additions & 0 deletions moveit_kinematics/cached_ik_kinematics_plugin/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,23 @@ ament_target_dependencies(${MOVEIT_LIB_NAME}
moveit_msgs
)

<<<<<<< HEAD
=======
target_link_libraries(
moveit_cached_ik_kinematics_base PUBLIC cached_ik_kinematics_parameters
kdl_kinematics_parameters)

add_library(moveit_cached_ik_kinematics_plugin SHARED
src/cached_ik_kinematics_plugin.cpp)
set_target_properties(moveit_cached_ik_kinematics_plugin
PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
ament_target_dependencies(moveit_cached_ik_kinematics_plugin PUBLIC rclcpp
moveit_core moveit_msgs rsl)
target_link_libraries(
moveit_cached_ik_kinematics_plugin
PRIVATE cached_ik_kinematics_parameters moveit_kdl_kinematics_plugin
moveit_srv_kinematics_plugin moveit_cached_ik_kinematics_base)
>>>>>>> b5eb4deb3 (Remove plugins from export set (#3227))
if(trac_ik_kinematics_plugin_FOUND)
include_directories(${trac_ik_kinematics_plugin_INCLUDE_DIRS})
endif()
Expand Down
16 changes: 16 additions & 0 deletions moveit_ros/move_group/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ ament_target_dependencies(moveit_move_group_default_capabilities ${THIS_PACKAGE_
target_link_libraries(moveit_move_group_default_capabilities moveit_move_group_capabilities_base)

install(
<<<<<<< HEAD
TARGETS
move_group
list_move_group_capabilities
Expand All @@ -84,13 +85,28 @@ install(
moveit_move_group_default_capabilities
moveit_move_group_capabilities_base
EXPORT export_${PROJECT_NAME}
=======
TARGETS moveit_move_group_capabilities_base
EXPORT moveit_ros_move_groupTargets
>>>>>>> b5eb4deb3 (Remove plugins from export set (#3227))
LIBRARY DESTINATION lib
ARCHIVE DESTINATION lib
RUNTIME DESTINATION bin
INCLUDES DESTINATION include
)

<<<<<<< HEAD
install(DIRECTORY include/ DESTINATION include)
=======
install(
TARGETS moveit_move_group_default_capabilities
EXPORT moveit_move_group_default_capabilitiesTargets
LIBRARY DESTINATION lib
ARCHIVE DESTINATION lib
RUNTIME DESTINATION bin)

install(DIRECTORY include/ DESTINATION include/moveit_ros_move_group)
>>>>>>> b5eb4deb3 (Remove plugins from export set (#3227))

ament_export_targets(export_${PROJECT_NAME} HAS_LIBRARY_TARGET)
ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS})
Expand Down
Loading