Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugins from export set (backport #3227) #3241

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 13, 2025

Description

Plugins that are intended to be loaded by classloader or pluginlib should not be in export sets that ament_export_targets is called on. This can cause plugins to fail to load.


This is an automatic backport of pull request #3227 done by Mergify.

* Remove plugins from export set

Signed-off-by: Paul Gesel <[email protected]>

* move more plugins to different export set

Signed-off-by: Paul Gesel <[email protected]>

* run pre-commit

Signed-off-by: Paul Gesel <[email protected]>

* remove plugins from moveit_kinematics export

Signed-off-by: Paul Gesel <[email protected]>

* do not link base interface to plugin in kinematics

Signed-off-by: Paul Gesel <[email protected]>

---------

Signed-off-by: Paul Gesel <[email protected]>
Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit b5eb4de)

# Conflicts:
#	moveit_core/CMakeLists.txt
#	moveit_kinematics/CMakeLists.txt
#	moveit_kinematics/cached_ik_kinematics_plugin/CMakeLists.txt
#	moveit_ros/move_group/CMakeLists.txt
@mergify mergify bot added the conflicts label Jan 13, 2025
Copy link
Author

mergify bot commented Jan 13, 2025

Cherry-pick of b5eb4de has failed:

On branch mergify/bp/humble/pr-3227
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit b5eb4deb3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_core/CMakeLists.txt
	both modified:   moveit_kinematics/CMakeLists.txt
	both modified:   moveit_kinematics/cached_ik_kinematics_plugin/CMakeLists.txt
	both modified:   moveit_ros/move_group/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@sea-bass sea-bass requested review from pac48 and sjahr January 13, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant