Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Servo] Fix collision checking with attached objects #2747

Merged
merged 3 commits into from
Mar 19, 2024
Merged

[Servo] Fix collision checking with attached objects #2747

merged 3 commits into from
Mar 19, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Mar 18, 2024 •
edited
Loading

Description

This PR introduces a slight fix to the MoveIt Servo collision checker to make it work with attached objects.

Turns out Current State Monitor has some issues, but Planning Scene Monitor works fine: #2748

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass requested a review from henningkayser March 18, 2024 19:00
@sea-bass sea-bass self-assigned this Mar 18, 2024
@sea-bass sea-bass requested a review from AndyZe March 18, 2024 19:00
@sea-bass sea-bass mentioned this pull request Mar 18, 2024
Open
@sea-bass
Copy link
Contributor Author

sea-bass commented Mar 18, 2024 •
edited
Loading

CI failures seem to be from #2749

sjahr
sjahr approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a small comment that explains why getPlanningScene() is used instead of getStateMonitor? Worst case, someone casually switches it back next time the code is touched 😓

@henningkayser henningkayser added the backport-iron Mergify label that triggers a PR backport to Iron label Mar 19, 2024
@henningkayser henningkayser merged commit 68e8680 into main Mar 19, 2024
5 of 12 checks passed
@henningkayser henningkayser deleted the fix-servo-collision-attached-obj branch March 19, 2024 14:04
mergify bot pushed a commit that referenced this pull request Mar 19, 2024
@sea-bass @mergify
[Servo] Fix collision checking with attached objects (#2747)
80e173a 
(cherry picked from commit 68e8680)
@mergify mergify bot mentioned this pull request Mar 19, 2024
Merged
6 tasks
sjahr pushed a commit that referenced this pull request Mar 22, 2024
@mergify @sea-bass
[Servo] Fix collision checking with attached objects (#2747) (#2754)
5108826 
(cherry picked from commit 68e8680)

Co-authored-by: Sebastian Castro <[email protected]>
@sea-bass sea-bass linked an issue May 3, 2024 that may be closed by this pull request
CurrentStateMonitor does not correctly report attached collision objects, but PlanningSceneMonitor does. #2748
Open
@sea-bass sea-bass mentioned this pull request Nov 3, 2024
Merged
6 tasks
@sea-bass sea-bass removed a link to an issue Nov 3, 2024
CurrentStateMonitor does not correctly report attached collision objects, but PlanningSceneMonitor does. #2748
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

@sjahr sjahr sjahr approved these changes

@AndyZe AndyZe Awaiting requested review from AndyZe

Assignees

@sea-bass sea-bass

Labels
backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sea-bass @henningkayser @sjahr