DOCSP-41134: Retrieve Data #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for docs-kotlin-sync pending review.Visit the deploys page to approve it
|
rustagir
requested changes
Jul 11, 2024
source/read/retrieve.txt
Outdated
| The ``find()`` method retrieves documents from a collection. This | ||
| method takes a **query filter** and returns all matching documents. A query filter is a | ||
| document that specifies the criteria that the driver uses to match documents from the | ||
| collection. | ||
|
|
||
| .. To learn more about query filters, see :ref:`kotlin-sync-specify-query`. |
There was a problem hiding this comment.
S: Add a TODO here because it makes these easy to find if they fall through the cracks
source/includes/read/retrieve.kt
Outdated
| // end-find | ||
|
|
||
| // start-find-iterate | ||
| val resultsToPrint = collection.find(eq("cuisine", "Spanish")) |
There was a problem hiding this comment.
S: even though it produces errors in the IDE, can you call all of these variables just results
Also applies to lines 26, 32, 36
source/read/retrieve.txt
Outdated
Comment on lines
64
to
69
| .. literalinclude:: /includes/read/retrieve.kt | ||
| :start-after: start-find-iterate | ||
| :end-before: end-find-iterate | ||
| :language: kotlin | ||
| :copyable: | ||
| :dedent: |
There was a problem hiding this comment.
S: convert this to an IO code block and show some sample documents returned
source/includes/read/retrieve.kt
Outdated
| // end-find-all | ||
|
|
||
| // start-modified-find | ||
| val modifiedResults = collection.find(eq("cuisine", "Spanish")).limit(10).maxTime(10000) |
There was a problem hiding this comment.
S: reduce horizontal scroll
Suggested change
| val modifiedResults = collection.find(eq("cuisine", "Spanish")).limit(10).maxTime(10000) | |
| val modifiedResults = collection | |
| .find(eq("cuisine", "Spanish")) | |
| .limit(10) | |
| .maxTime(10000) |
source/read/retrieve.txt
Outdated
Comment on lines
101
to
102
| * - ``collation()`` | ||
| - | An instance of the ``Collation`` class that sets the collation options. |
There was a problem hiding this comment.
S: change all descriptions to be the same part of speech
Suggested change
| * - ``collation()`` | |
| - | An instance of the ``Collation`` class that sets the collation options. | |
| * - ``collation()`` | |
| - | Sets the collation options for the query. |
source/read/retrieve.txt
Outdated
Comment on lines
104
to
108
| * - ``comment()`` | ||
| - | A string to attach to the query. This can help you trace and interpret the | ||
| operation in the server logs and in profile data. To learn more about query comments, | ||
| see :manual:`$comment </reference/operator/query/comment/>` in the MongoDB Server | ||
| manual. |
There was a problem hiding this comment.
Suggested change
| * - ``comment()`` | |
| - | A string to attach to the query. This can help you trace and interpret the | |
| operation in the server logs and in profile data. To learn more about query comments, | |
| see :manual:`$comment </reference/operator/query/comment/>` in the MongoDB Server | |
| manual. | |
| * - ``comment()`` | |
| - | Specifies a string to attach to the query. This can help you trace and interpret the | |
| operation in the server logs and in profile data. To learn more about query comments, | |
| see :manual:`$comment </reference/operator/query/comment/>` in the MongoDB Server | |
| manual. |
source/read/retrieve.txt
Outdated
Comment on lines
144
to
145
| For runnable code examples of retrieving documents with the {+driver-short+}, see | ||
| :ref:`kotlin-sync-read`. |
There was a problem hiding this comment.
Suggested change
| For runnable code examples of retrieving documents with the {+driver-short+}, see | |
| :ref:`kotlin-sync-read`. | |
| To view runnable code examples that retrieve documents by using the {+driver-short+}, see | |
| :ref:`kotlin-sync-read`. |
rustagir
approved these changes
Jul 11, 2024
source/read/retrieve.txt
Outdated
| free MongoDB Atlas cluster and load the sample datasets, see the | ||
| :atlas:`Get Started with Atlas </getting-started>` guide. | ||
|
|
||
| This data is modeled with the following Kotlin data class: |
There was a problem hiding this comment.
S: use language source constant where applicable
Suggested change
| This data is modeled with the following Kotlin data class: | |
| The documents in this collection are modeled by the following {+language+} data class: |
mcmorisi
requested review from
a team and
vbabanin
and removed request for
a team
This was referenced Jul 15, 2024
mcmorisi
added a commit
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 1db6789)
mcmorisi
added a commit
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 1db6789)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41134
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41134/read/retrieve/
Self-Review Checklist