Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-41136: Specify Documents to Return #10

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

mcmorisi
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41135
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/kotlin-sync/DOCSP-41136-specify-documents/read/specify-documents-to-return/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jul 15, 2024

👷 Deploy request for docs-kotlin-sync pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f9536ee


.. TODO: For more information about specifying a query, see :ref:`kotlin-sync-specify-query`.

For more information about retrieving documents, see :ref:`kotlin-sync-retrieve`.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: The retrieve page here is currently also in review. This PR should be merged in after the retrieve page is merged.

Link to Retrieve page PR

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! LGTM % a few small changes and suggestions.

Comment on lines 26 to 28
- ``limit()``: Specifies the maximum number of documents to return from a query.
- ``sort()``: Specifies the sort order for the returned documents.
- ``skip()``: Specifies the number of documents to skip before returning query results.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: I don't think these should have periods

Suggested change
- ``limit()``: Specifies the maximum number of documents to return from a query.
- ``sort()``: Specifies the sort order for the returned documents.
- ``skip()``: Specifies the number of documents to skip before returning query results.
- ``limit()``: Specifies the maximum number of documents to return from a query
- ``sort()``: Specifies the sort order for the returned documents
- ``skip()``: Specifies the number of documents to skip before returning query results

Comment on lines 77 to 78
The preceding example returns the first five documents returned by the query in
no particular order. The following section describes how to return the documents
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: Technically the docs are returned in natural order

Suggested change
The preceding example returns the first five documents returned by the query in
no particular order. The following section describes how to return the documents
The preceding example returns the first five documents returned by the query in
:manual:`natural order </reference/glossary/#std-term-natural-order>`. The following section describes how to return the documents

source/read/specify-documents-to-return.txt Outdated Show resolved Hide resolved
source/read/specify-documents-to-return.txt Outdated Show resolved Hide resolved
source/read/specify-documents-to-return.txt Outdated Show resolved Hide resolved
source/read/specify-documents-to-return.txt Outdated Show resolved Hide resolved
@mcmorisi mcmorisi requested review from a team and vbabanin and removed request for a team July 15, 2024 17:15
@tom-selander tom-selander requested review from rozza and removed request for vbabanin July 17, 2024 14:54
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmorisi mcmorisi merged commit 83432bc into mongodb:master Jul 18, 2024
1 of 2 checks passed
@mcmorisi mcmorisi deleted the DOCSP-41136-specify-documents branch July 18, 2024 13:18
mcmorisi added a commit that referenced this pull request Jul 18, 2024
mcmorisi added a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants