Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate some unnecessary nesting in the reference docs #2899

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Feb 25, 2025

Now that we're pulling FunctionCall up to the top-level namespace, we should also include it in the sidebar of the reference docs rather than hiding it on the page that you get to if you click modal.Function.

While looking into this, I noticed that a few other objects were the only public object defined in their module, but we were for some reason configuring their reference to represent the module. This doesn't seem necessary; I removed it so that the references docs are more consistently formatted across types.

e.g., before:

image

and after:

image

Also, hey buddy 👋

image

@mwaskom mwaskom requested a review from ekzhang February 25, 2025 19:49
@mwaskom mwaskom merged commit d8fed17 into main Feb 25, 2025
24 checks passed
@mwaskom mwaskom deleted the michael/2025-02-25-function-call-docs branch February 25, 2025 20:55
mwaskom added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants