Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for objects defined in submodules #2901

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Feb 25, 2025

Follow-up to #2899; a couple of objects were documented as if they are in the top-level namespace, but they aren't.

@mwaskom mwaskom force-pushed the michael/2025-02-25-fix-container-process-docs branch from 8d52c0b to f8b5945 Compare February 25, 2025 23:32
@mwaskom mwaskom requested a review from ekzhang February 25, 2025 23:37
a [`ContainerProcess`](/docs/reference/modal.ContainerProcess#modalcontainer_process) handle.
"""Execute a command in the Sandbox and return a ContainerProcess handle.

See the [`ContainerProcess`](/docs/reference/modal.container_process#modalcontainer_processcontainerprocess)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super ugly :/

@mwaskom
Copy link
Contributor Author

mwaskom commented Feb 25, 2025

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @ekzhang will follow-up review this.

Copy link
Member

@ekzhang ekzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mwaskom mwaskom merged commit 725b1ef into main Feb 25, 2025
24 checks passed
@mwaskom mwaskom deleted the michael/2025-02-25-fix-container-process-docs branch February 25, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants