Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for accidentally *fixing* @build deps #2889

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Quick fix for accidentally *fixing* @build deps #2889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modal/_runtime/user_code_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,9 @@ def import_single_function_service(
# The cls decorator is in global scope
_cls = synchronizer._translate_in(cls)
user_defined_callable = _cls._callables[fun_name]
service_deps = _cls._get_class_service_function().deps(only_explicit_mounts=True)
# Intentionally not including these, since @build functions don't actually
# forward the information from their parent class.
# service_deps = _cls._get_class_service_function().deps(only_explicit_mounts=True)
active_app = _cls._app
else:
# This is non-decorated class
Expand Down
Loading